Skip to content

Fix bug found during tax residency issuance #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LuisPereira23 merged 5 commits into from
May 21, 2026
Merged

Fix bug found during tax residency issuance #162

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77507b1
Update formatter to normalize claim 'address' from list to json only …
MarianaFilipa May 15, 2026
49fad81
Merge pull request #68 from niscy-eudiw/fix-bug-issuing-tax-residency
MarianaFilipa May 15, 2026
dfbd25c
refactor: remove duplicated code
MarianaFilipa May 18, 2026
cd4f42e
Merge pull request #70 from niscy-eudiw/fix-bug-issuing-tax-residency
MarianaFilipa May 18, 2026
ddf83e1
Merge pull request #69 from niscy-eudiw/dev-internal
LuisPereira23 May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions app/dynamic_func.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def formatter(data, un_distinguishing_sign, scope, format):
)

# Normalize list and type fields
normalize_list_and_type_fields(data, attributes_req, attributes_req2)
normalize_list_and_type_fields(data, attributes_req, attributes_req2, requested_credential.get("scope"))

# Populate pdata
populate_pdata(
Expand Down Expand Up @@ -248,18 +248,20 @@ def update_dates_and_special_claims(
data["credential_type"] = doctype_config["credential_type"]


def normalize_list_and_type_fields(data, attributes_req, attributes_req2):
def normalize_list_and_type_fields(data, attributes_req, attributes_req2, scope=None):
list_fields = [
"places_of_work",
"legislation",
"employment_details",
"competent_institution",
"credential_holder",
"subject",
"residence_address",
"address"
"residence_address"
]

if scope == "eu.europa.ec.eudi.pid_vc_sd_jwt":
list_fields.append("address")

for field in list_fields:
if field in attributes_req and field in data:
if isinstance(data[field], str):
Expand All @@ -285,7 +287,6 @@ def normalize_list_and_type_fields(data, attributes_req, attributes_req2):
):
data["gender"] = int(data["gender"])


def populate_pdata(
data,
pdata,
Expand Down
Loading