Skip to content

fix(oidc): assign credential_issuer before use in credential offer endpoint#155

Merged
LuisPereira23 merged 1 commit into
eu-digital-identity-wallet:mainfrom
matteo-cristino:fix/credential_offer_create
May 14, 2026
Merged

fix(oidc): assign credential_issuer before use in credential offer endpoint#155
LuisPereira23 merged 1 commit into
eu-digital-identity-wallet:mainfrom
matteo-cristino:fix/credential_offer_create

Conversation

@matteo-cristino

Copy link
Copy Markdown
Contributor

No description provided.

@matteo-cristino

Copy link
Copy Markdown
Contributor Author

Over the past days, pipelines on credimi.io that use the credential_offer_create endpoint to create a credential offer have been failing to run. The root cause appears to be the missing credential_issuer assignment.
This PR fixes the assignment to restore correct behavior.

@matteo-cristino matteo-cristino force-pushed the fix/credential_offer_create branch from 61c1657 to cd9d79a Compare May 13, 2026 15:21
@matteo-cristino

Copy link
Copy Markdown
Contributor Author

Gentle bump on this PR — I’ve updated the branch to latest commit on main and it should be ready for review.

This is blocking our pipeline, so any feedback or a review would be much appreciated. Thanks!

@LuisPereira23 LuisPereira23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Reviewed. Assignment is indeed missing

@MarianaFilipa MarianaFilipa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

@LuisPereira23

Copy link
Copy Markdown
Collaborator

@matteo-cristino Thank you for noticing the missing assignment and submitting a fix!

@LuisPereira23 LuisPereira23 merged commit 416eb7f into eu-digital-identity-wallet:main May 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants