Fix double-escaped newlines in market metadata TSV cache#5
Merged
Conversation
The backfill script's loadExistingTsv had a buggy unescape (sequential regex replaces interfered with each other), causing every \n / \r / \t escape to gain an extra backslash on each re-write. Each round trip turned \\n into \\\n in the TSV; postgres COPY then decoded that as literal backslash + LF, which is invalid inside JSON. Fix: collapse every \\\n / \\\r / \\\t back to the correct \\n / \\r / \\t form. Verified by loading the resulting TSV into postgres without errors (COPY 40308) and round-tripping a sample row through jsonb. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backfill script's loadExistingTsv had a buggy unescape (sequential regex replaces interfered with each other), causing every \n / \r / \t escape to gain an extra backslash on each re-write. Each round trip turned \n into \\n in the TSV; postgres COPY then decoded that as literal backslash + LF, which is invalid inside JSON.
Fix: collapse every \\n / \\r / \\t back to the correct \n / \r / \t form. Verified by loading the resulting TSV into postgres without errors (COPY 40308) and round-tripping a sample row through jsonb.