Skip to content

Add focusgroup attribute as valid prop#3390

Open
djmarland wants to merge 1 commit into
emotion-js:mainfrom
djmarland:patch-1
Open

Add focusgroup attribute as valid prop#3390
djmarland wants to merge 1 commit into
emotion-js:mainfrom
djmarland:patch-1

Conversation

@djmarland

Copy link
Copy Markdown

What:

Adding focusgroup to the list of valid props

Why:

focusgroup is an upcoming attribute for HTML elements.

Currently, we are unable to test & use this attribute as it fails the is-valid-prop check in Linaria

How:

Simply adding to the allow-list. No logic changes.

Checklist:

  • Documentation - N/A
  • Tests - N/A
  • Code complete - N/A
  • Changeset - N/A

[`focusgroup`](https://microsoftedge.github.io/Demos/focusgroup/) is an upcoming attribute for HTML elements.

Currently, we are unable to test & use this attribute as it fails the is-valid-prop check in Linaria
Copilot AI review requested due to automatic review settings July 24, 2026 13:29
@changeset-bot

changeset-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 11be4f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the upcoming HTML focusgroup attribute to @emotion/is-prop-valid’s allow-list so it passes Linaria’s is-valid-prop checks and can be used/tested without being filtered.

Changes:

  • Add focusgroup to the props allow-list in @emotion/is-prop-valid.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants