[@emotion/is-prop-valid] Adds command and commandForElement to allowed props#3374
Open
Shoonkey wants to merge 1 commit into
Open
[@emotion/is-prop-valid] Adds command and commandForElement to allowed props#3374Shoonkey wants to merge 1 commit into
command and commandForElement to allowed props#3374Shoonkey wants to merge 1 commit into
Conversation
* feat(is-prop-valid): add support for Invoker Commands API
🦋 Changeset detectedLatest commit: 36a32e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Shoonkey
changed the title
command and commandForElement to allowed propscommand and commandForElement to allowed props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Addition of
commandandcommandForElementto allowed propsWhy: Currently the package considers these two props from the Invoker Commands API
How: By adding the mentioned props to
props.js, the file that contains the list of valid props.Checklist: