Potential fix for code scanning alert no. 10: Client-side cross-site scripting#6
Open
earlution wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 10: Client-side cross-site scripting#6earlution wants to merge 1 commit into
earlution wants to merge 1 commit into
Conversation
…scripting Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/earlution/6-axis-compass/security/code-scanning/10
To fix this safely without changing functionality, ensure any untrusted values interpolated into HTML are escaped for HTML attribute context before being included in template strings used with
innerHTML.Best single fix: in
src/merch.js, updatebuildMockupHTMLsogarmentId,garmentColor, andsrcare escaped before insertion into HTML attributes. Add a small local helper (e.g.,escapeHtmlAttr) that replaces& < > " 'with entities. This keeps current rendering behavior while preventing attribute/context breaking and script injection.Change region:
src/merch.js: aroundbuildMockupHTML(lines 22–31 in provided snippet), inserting helper function above it and using escaped values in the returned template.No other files are required for this fix.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.