Mandatory states logic#33
Draft
najirod02 wants to merge 1 commit into
Draft
Conversation
Open
Author
|
The warnings left by clang are about the stm32 auto-generated files and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce the logic for the driver-independent states (INIT, IDLE, FATAL, FLASH, and PAUSE). Isolating these mandatory states into a dedicated pull request ensures a strict and focused review of the ECU's core.
Overview
This PR implements the state execution for the five base states. The logic integrates previously developed core modules alongside external dependencies like PAL and Canlib.
Guidance
Beyond verifying the execution logic of each individual state, it is still important to verify the architectural modularity.
(e.g ensure that abstraction boundaries are clean, maintaining strict separation between function signatures and their implementation).