Skip to content

OfficeOnlineServerInstall, OfficeOnlineServerInstallLanguagePack: Add -WorkingDirectory to Start-Process#74

Open
raandree wants to merge 2 commits into
dsccommunity:masterfrom
raandree:fix/#73
Open

OfficeOnlineServerInstall, OfficeOnlineServerInstallLanguagePack: Add -WorkingDirectory to Start-Process#74
raandree wants to merge 2 commits into
dsccommunity:masterfrom
raandree:fix/#73

Conversation

@raandree

@raandree raandree commented Mar 11, 2026

Copy link
Copy Markdown

Pull Request (PR) description

Added -WorkingDirectory to the Start-Process call in Set-TargetResource
of both OfficeOnlineServerInstall and OfficeOnlineServerInstallLanguagePack.

Without this parameter, the working directory during DSC execution is inherited
from the LCM host process (typically System32), causing setup.exe to not find
.\files\setupsilent\config.xml. This results in exit code 30066 on
Windows Server 2025.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

…source for OfficeOnlineServerInstall and OfficeOnlineServerInstallLanguagePack
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@raandree has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea15bbe8-5d1b-491a-b545-53069e1f3fe9

📥 Commits

Reviewing files that changed from the base of the PR and between 6b6ce1f and 47ed624.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • azure-pipelines.yml
  • src/DSCResources/MSFT_OfficeOnlineServerInstall/MSFT_OfficeOnlineServerInstall.psm1
  • src/DSCResources/MSFT_OfficeOnlineServerInstallLanguagePack/MSFT_OfficeOnlineServerInstallLanguagePack.psm1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raandree raandree requested a review from johlju March 11, 2026 13:28
@raandree raandree self-assigned this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OfficeOnlineServerInstallLanguagePack: Start-Process missing -WorkingDirectory causes exit code 30066 on Windows Server 2025

1 participant