feat(env): remove macOS keychain and pass secret providers#3713
Merged
Conversation
Simplify the secret provider chain to shell env, env files, credential helper, and Docker Desktop. Drop the pass and security backends and their write-side stores; update the setup wizard to skip the store-picker when only one store is available. Assisted-By: docker-agent
Guard against empty secret-store list in storeSecret; add chmod 600 to env-file snippet; add migration note for keys previously in Keychain/pass. Assisted-By: Claude
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
🟢 No issues found — LGTM! View logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS Keychain (
security) andpassintegrations added complexity for a narrow use case: they required external tooling, produced confusing errors when those tools were absent, and duplicated the role of the simpler~/.config/cagent/.envfile store. Removing them shrinks the surface area, eliminates a class of setup failures, and makes the secret-storage story uniform across platforms.DefaultSourcesno longer includes the keychain or pass environment providers.SecretStores()now returns only the Docker Agent env file store. Thedocker agent setupwizard skips the "where should the key be stored?" prompt when only one store is available and fails fast with a clear error if storing fails.SecretSourcesHelpnow points users to shell env vars,--env-from-file, anddocker agent setupinstead ofpass/securitycommands. The secrets guide, getting-started pages, CLI feature doc, and troubleshooting guide are all updated to match, with a migration note for anyone who previously stored keys via Keychain orpass.The OAuth keyring token store (
pkg/tools/mcp/keyringstore) and the registry credential keychain (pkg/remote) are unrelated to secret providers and are intentionally untouched.