Skip to content

python 3 fixes for other submodules, some pep8#67

Open
kavdev wants to merge 7 commits into
django-nonrel:masterfrom
kavdev:master
Open

python 3 fixes for other submodules, some pep8#67
kavdev wants to merge 7 commits into
django-nonrel:masterfrom
kavdev:master

Conversation

@kavdev

@kavdev kavdev commented Aug 11, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@kavdev kavdev mentioned this pull request Aug 11, 2015
Closed
@aburgel

aburgel commented Aug 13, 2015

Copy link
Copy Markdown
Member

this looks like a less extensive set of changes than #66. i don't use python 3 so i don't know what changes are necessary. can you let me know whether i should merge both PRs?

@kavdev

kavdev commented Aug 14, 2015

Copy link
Copy Markdown
Contributor Author

The changes in #66 uses 2to3 to automatically alter the code to work with python 3, including 3.0 and 3.1.

  1. It's become convention to target 3.2+ to avoid dealing with the screwy api of 3.0 and 3.1
  2. Some of the changes made aren't backwards compatible.

That being said I missed a few things like iteritems() calls. I'll update this PR tomorrow.

@kavdev

kavdev commented Oct 21, 2015

Copy link
Copy Markdown
Contributor Author

should be all set. sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants