docs: fix duplicate aria-current and ProgressBar label typo in examples#2445
Merged
frankensteinke merged 2 commits intoJun 25, 2026
Merged
Conversation
- TwoColumnPanel example set aria-current twice on the same <a>; drop the duplicate so copy/pasted samples are not confusing. - ProgressBar animated example aria-label read "Animated Progres"; correct to "Animated Progress". Both surfaced by Copilot review on #2443.
frankensteinke
marked this pull request as ready for review
June 22, 2026 09:31
frankensteinke
enabled auto-merge (squash)
June 22, 2026 09:31
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two pre-existing accessibility/content issues in component documentation examples so copy/pasted snippets are correct and less confusing.
Changes:
- Remove a duplicate
aria-currentattribute from theTwoColumnPaneldocs example anchor. - Fix a typo in the
ProgressBaranimated examplearia-label(“Progres” → “Progress”).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/pages/components/TwoColumnPanel.mdx | Drops the duplicate aria-current on the example <a> to avoid conflicting/invalid sample markup. |
| docs/pages/components/ProgressBar.mdx | Corrects the aria-label typo in the animated ProgressBar example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…ent-dup-and-progressbar-typo # Conflicts: # docs/pages/components/ProgressBar.mdx # docs/pages/components/TwoColumnPanel.mdx
anastasialanz
approved these changes
Jun 25, 2026
frankensteinke
deleted the
docs/fix-aria-current-dup-and-progressbar-typo
branch
June 25, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two pre-existing content bugs in component doc examples, surfaced by Copilot review on #2443 (the Prettier sweep, which only reformatted these lines and didn't introduce the issues):
aria-currenttwice on the same<a>; dropped the duplicate so copy/pasted samples aren't confusing.aria-labelread "Animated Progres"; corrected to "Animated Progress".Kept separate from #2443 so that PR stays a pure mechanical formatting diff.
Note on merge order
Both lines are also reformatted by #2443. Whichever of these two PRs merges second will need a trivial rebase.