fix(docs): use named minimatch import#2433
Merged
Merged
Conversation
minimatch v10 is ESM-only and exposes named exports with no default, so
'import minimatch from minimatch' resolves to undefined — webpack warns
('export default not found') and collections.ts would throw
'minimatch is not a function' at runtime. Switch to the named import
'import { minimatch }'. Surfaced once minimatch was declared as a direct
dep at ^10 (#2417); previously an older CJS minimatch with a default
export was hoisted to the top of node_modules and resolved here by
accident.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the docs site build by updating the minimatch import in docs/collections.ts to use the named minimatch export, which is required for minimatch@10 (ESM-only).
Changes:
- Replace the default
minimatchimport with a named import ({ minimatch }) to matchminimatch@10’s export shape.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
anastasialanz
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/collections.tsimported minimatch as a default export, but minimatch v10 (which we pinned in #2417) is ESM-only with named exports. This was breaking the docs site.