Skip to content

Merges (almost) all open PRs, plus several small fixes that haven't been submitted#903

Draft
clarinetJWD wants to merge 18 commits into
denysdovhan:mainfrom
clarinetJWD:main
Draft

Merges (almost) all open PRs, plus several small fixes that haven't been submitted#903
clarinetJWD wants to merge 18 commits into
denysdovhan:mainfrom
clarinetJWD:main

Conversation

@clarinetJWD

Copy link
Copy Markdown

Hey @denysdovhan (and everyone who has contributed here)!

I spent the past couple days compiling all open PRs (aside from chores and one request that could be accomplished better with Stats IMO) into this repository. I've tested all of the changes myself, but make no promises that it'll work in all environments.

I have my repository set up to be used as a custom HACS repository, so feel free to grab the updated card from there.

@denysdovhan - When you're back to working on this project, let me know how you want to handle this! I want to make sure all the contributors get their credit, but I improved several of the features/fixes, so I want to make sure everything gets in.

I guess the simplest solution would be that once you've reviewed and merged all the code, let me know, and I'll diff it with this version and compile a minimal update list.

Much love <3

fix: Fixes an issue where specifying `vc-background:` in the theme file was being ignored and overwritten by the default card color.
Fixed an issue where you could not unselect the camera (or water level sensor)
…erly initialize or control the state of the card.
Added status template (from PR by phox142 )

New Fixes:
1. Moved ha-template into this project because it had a significant bug that caused updates to not be applied.
2. Fixed the issue of the template not re-applying on state changes.
3. Removed the ha-tempalte package from the package and package-lock json files since it's integrated now. TODO - Split back out once the bug-fix is in the other project.
4. PR had status_template in some places, value_template in others. Made this consistent as "status_template".
5. Fixed image editor in the config UI
6. Added editor for status_template in the config UI
Updates this repository with (almost) all open PR requests from the base repository
@denysdovhan

Copy link
Copy Markdown
Owner

Hey! Your PR break some of the existing feature (like images and vacuum maps) and unpublished work.
Thanks for making the effort, though! Maybe that will be useful for folks who like to have all the latest features.

I'll start going over PRs and issues one by one and resolved them to keep the project up to date. Overall, this project is quite stable and serves my needs well. Nonetheless, I'll try my best to keep it in a good condition.

Sorry for making a pause in maintaining this project: I had a lot of personal stuff going on, not mentioning life in war is stressful. I am trying to keep my mental state as normal as possible in these conditions, so it requires spending more time out of keyboard.

If folks like this project and want to support the effort, please consider donating your daily cup of coffee here:

@clarinetJWD

Copy link
Copy Markdown
Author

Hey! Your PR break some of the existing feature (like images and vacuum maps) and unpublished work. Thanks for making the effort, though! Maybe that will be useful for folks...

Hey, thanks for replying! I thought I checked the image and maps features, but I'd be glad to fix anything that I inadvertently broke! Once you're done going through stuff, I'll do a compare and see what little cleanup and tweaks I have left.

And, of course, we ALL understand the pressures of life, and that being in Ukraine is its own huge deal right now, so there is no need to apologize at all (hell, I have a few branches that I haven't updated in years, and my only excuse is ADHD). It's why I left all of your information on the fork readme: you deserve all the credit and support for sure!

I was just trying to come up with a stop-gap solution while you dealt with life (it's why this is only a draft PR, too). Thank you for all your hard work! Much love here from Texas! 🤠 🇺🇦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants