Skip to content

fix(ci): stabilize release and core e2e checks #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
izadoesdev merged 4 commits into from
Jul 26, 2026
+12 −11
Merged

fix(ci): stabilize release and core e2e checks #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
583e247
Merge pull request #541 from databuddy-analytics/staging
izadoesdev Jul 23, 2026
367b476
Merge pull request #569 from databuddy-analytics/staging
izadoesdev Jul 25, 2026
076400f
fix(ci): only run releases for changesets
izadoesdev Jul 26, 2026
145503c
fix(dashboard): align core e2e checks with current UI
izadoesdev Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ name: Release
on:
push:
branches: [main]
paths:
- ".changeset/**"

concurrency:
group: release-${{ github.ref }}
Expand Down
9 changes: 1 addition & 8 deletions apps/dashboard/test/e2e/specs/core/links.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ test(
).toBeVisible();

await createLinkFolder(authenticatedPage, folderName);
await expect(
authenticatedPage.getByRole("button", { name: new RegExp(folderName) })
).toBeVisible();

const primaryRow = await createShortLink(authenticatedPage, {
folderName,
Expand All @@ -45,11 +42,7 @@ test(
});
await expect(primaryRow).toBeVisible();
await expect(authenticatedPage.getByText(escapedText(primarySlug))).toBeVisible();
await expect(
authenticatedPage.getByRole("button", {
name: new RegExp(`${folderName}\\s+1`),
})
).toBeVisible();
await expect(authenticatedPage.getByText(folderName, { exact: true })).toBeVisible();

const secondaryRow = await createShortLink(authenticatedPage, {
name: secondaryName,
Expand Down
8 changes: 6 additions & 2 deletions apps/dashboard/test/e2e/specs/core/websites.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,12 @@ test(
const websiteId = idFromPath(authenticatedPage.url(), "websites");

await authenticatedPage.goto(`/websites/${websiteId}/settings/general`);
await expect(authenticatedPage.getByText(websiteName)).toBeVisible();
await expect(authenticatedPage.getByText(domain)).toBeVisible();
await expect(
authenticatedPage.getByRole("textbox", { name: "Name" })
).toHaveValue(websiteName);
await expect(
authenticatedPage.getByRole("textbox", { name: "Domain" })
).toHaveValue(domain);

await authenticatedPage.getByRole("button", { name: "Edit" }).first().click();
await expect(
Expand Down
4 changes: 3 additions & 1 deletion apps/dashboard/test/e2e/utils/dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ export async function createLinkFolder(
await page.getByRole("heading", { name: "Create Folder" }).waitFor();
await page.getByRole("textbox", { name: "Folder Name" }).fill(folderName);
await page.getByRole("button", { name: "Create Folder" }).click();
await page.getByRole("button", { name: escapedText(folderName) }).waitFor();
await expect(
page.getByRole("heading", { name: "Create Folder" })
).toBeHidden();
}

export async function createShortLink(
Expand Down
Loading