Add support for TLS on JAK testserver#420
Open
barkha06 wants to merge 23 commits into
Open
Conversation
barkha06
commented
Jun 3, 2026
barkha06
commented
Contributor
- Created a KeyStoreService class that defines getTLSIdentity.
- Both Java and Android have different TLSIdentity method definitions so they each implement a subclass of KeyStoreService
- The getTLSIdentity method stores the generated identity data in the keystore and returns an instance of TLSIdentity class. If the idenitity is null and disableTLS is false, the method returns an existing identity from the keystore via the alias.
- Port is dynamically assigned by OS to avoid any address in use errors
- Added timout between test steps to avoid server disconnected errors
…' while setting port
borrrden
requested changes
Jun 4, 2026
| listener2 = Listener( | ||
| all_dbs[0], ["_default._default"], 59840, identity=None | ||
| ) | ||
| await asyncio.sleep(30) |
Member
There was a problem hiding this comment.
This is an excessively long sleep. What is it for? Please add a comment, the function name does not imply that this needs any wait time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.