Support for Mop mode, Support for (dynamic/multiple) Maps#3
Open
ultimate-tester wants to merge 12 commits into
Open
Support for Mop mode, Support for (dynamic/multiple) Maps#3ultimate-tester wants to merge 12 commits into
ultimate-tester wants to merge 12 commits into
Conversation
|
There is already a PR for the mop mode: 130404 |
|
Hi @ultimate-tester , can you update your PR with one the Support for (dynamic/multiple) Maps ? Regards |
Author
You mean only the support for maps? |
|
Yes as the mop mode is already exist now.
Le lun. 13 avr. 2026, 08:06, ultimate-tester ***@***.***> a
écrit :
… *ultimate-tester* left a comment (clarinetJWD/vacuum-card#3)
<#3 (comment)>
Hi @ultimate-tester <https://github.com/ultimate-tester> , can you update
your PR with one the Support for (dynamic/multiple) Maps ?
Regards
You mean only the support for maps?
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQ3GTR77Y4WNOWC4H6LJKT4VR7U7AVCNFSM6AAAAACXWHQFJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMZUGE4TQMRQGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I gave this beautiful card some attention over the weekend which I'd like to PR before it grows too large to merge easily.
I added the following:
mop_intensityconfiguration item.selected_mapyou can set the similarly named entity that some vacuums offer (like my Roborock S7), it will lookup the maps you have and list them in a dropdown menu at the top of the card. You can easily switch the map that way. Added bonus: if you use this configuration item, it will also automatically use the set map to show the map (only while the robot is running!). This means you no longer need to manually set the map using themapconfiguration item.