fix: stop double-check skill being dropped by skills.sh installer#179
Merged
Conversation
The double-check skill's frontmatter description contained an inline ": " (in "Provider-agnostic: it always picks..."). The skills.sh CLI (`npx skills add`) parses SKILL.md frontmatter with a strict YAML parser, which reads colon-space inside an unquoted plain scalar as a nested mapping and throws. parseSkillMd swallows the error and returns null, so the installer silently found 27 of 28 skills and double-check never landed in ~/.agents/skills/. Replace the colon with an em dash (matching the description's existing style) so the frontmatter parses. Add test/skills-frontmatter.sh to guard every skill's frontmatter against this class of YAML hazard so a skill can't silently vanish at install time again. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running the installer (
./install-claude.sh→npx skills add citypaul/.dotfiles -s '*') installed 27 of 28 skills —double-checksilently never landed in~/.agents/skills/, so it wasn't available to Claude Code, Codex, or any other agent.Root cause
The skills.sh CLI parses each
SKILL.mdfrontmatter with a strict YAML parser (yaml@2.x). Thedouble-checkdescription contained an inline": ":YAML reads colon-space inside an unquoted plain scalar as a nested mapping and throws:
The CLI's
parseSkillMdswallows the error and returnsnull, so the skill is dropped with no warning — the installer just reports one fewer skill.Fix
:with an em dash (Provider-agnostic — it always picks...), matching the em-dash style already used throughout the description. Verified the CLI now discovers 28 skills includingdouble-checkagainst the working tree.test/skills-frontmatter.sh(wired intotest/run.sh) to guard every skill'sname:/description:frontmatter against this class of YAML hazard (unquoted": "or" #"), so a skill can never again silently vanish at install time. Confirmed it fails when the bug is reintroduced and passes on the fix.Verification
npx skills add <local repo> -s '*' --dry-run→Found 28 skills(was 27), double-check copied../test/run.sh→ all tests pass.🤖 Generated with Claude Code