Fix docs: site URL, emoji rendering, pip→uv, and code snippet errors#302
Conversation
- Change site_url and all docs links from chekos.github.io/pypums to pypums.readthedocs.io - Add pymdownx.emoji extension to mkdocs.yml so :octicons-*: icons render - Replace all pip install references with uv add across docs and README - Remove pip/uv tabbed sections (just show uv) - Add Documentation URL to pyproject.toml - Fix multi-year.md: get_acs() state param only accepts str, not list - Fix spatial.md: parameter name n → dots_per_value in troubleshooting - Fix pums-microdata.md: pums_variables() → pypums.datasets.pums_variables() - Fix population-estimates.md: add missing AGEGROUP codes 13-17,30; expand abbreviated RACE labels to match source code - Add .claude/launch.json for mkdocs dev server Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f810659 to
05cdbb1
Compare
|
Claude finished @chekos's task in 1m 59s —— View job PR Review
All claims in the PR description were verified against source code. Here's my detailed review: Verified Fixes (All Correct ✓)
AGEGROUP codes 13–17 and 30 ( RACE label expansions ( Minor Observations1. Slight style inconsistency in
2. The troubleshooting section now suggests 3. Multi-year inner loop performance The fix at 4. A VS Code / Claude Code debug config for SummaryThis is a clean, well-scoped docs-only PR. All code snippet corrections are verified accurate against the actual source code. The URL fixes, emoji extension, and pip→uv migration are straightforward and correct. No bugs introduced. |
…re launch.json - Use `pypums.load_variables()` with full namespace in variables.md intro for consistency with `pypums.datasets.pums_variables()` in same sentence - Add inline comment clarifying get_acs() accepts one state at a time - Move .claude/launch.json to .gitignore (IDE-specific tooling config) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude finished @chekos's task in 50s —— View job PR Review — Updated
The latest commit ( 1. Namespace consistency in 2. Inner loop clarification in 3. SummaryAll previously identified issues have been addressed. The PR is clean — docs-only, well-scoped, with all code snippet corrections verified against source. Ready to merge. |
Summary
chekos.github.io/pypumstopypums.readthedocs.ioacross mkdocs.yml, README, CONTRIBUTING, and pyproject.tomlpymdownx.emojiextension to mkdocs.yml so:octicons-arrow-right-24:icons render instead of showing raw textpip installreferences withuv addacross all docs pages (installation, quickstart, guides, index)multi-year.md:get_acs(state=["CA","TX",...])passes a list but signature only acceptsstr | None— fixed with inner loopspatial.md: troubleshooting text referenced parameternbut actual name isdots_per_valuepums-microdata.md:pums_variables()not exported at top level — corrected topypums.datasets.pums_variables()population-estimates.md: AGEGROUP table missing codes 13-17,30; RACE labels abbreviated vs sourceTest plan
uv run mkdocs serverenders all pages without errors:octicons-arrow-right-24:) render correctly on the landing pageuv add(no remainingpip install)🤖 Generated with Claude Code