Complete documentation overhaul#301
Conversation
Rewrites the entire documentation site from scratch to match the current library capabilities (get_acs, get_pums, get_decennial, get_estimates, get_flows, MOE utilities, spatial support, survey design, caching, CLI). - Upgrade to mkdocs-material theme with tabs, code copy, admonitions - Rewrite README with hero examples, badges, and feature overview - Add Getting Started section: installation, quickstart, Census 101 - Add 12 topic guides: ACS, Decennial, PUMS, Estimates, Flows, Variables, Geography, MOE, Spatial, Survey Design, Caching, Multi-year - Add API reference with mkdocstrings, CLI reference, datasets reference - Add 3 migration guides: from tidycensus, from old PyPUMS, from FTP - Add troubleshooting sections across guides - Add cross-links between all guides and references - Remove outdated user-guide/, history.md, surveys.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude finished @chekos's task in 2m 14s —— View job PR Review: Complete Documentation Overhaul
SummaryThis is a substantial, well-structured documentation overhaul. The 25 new/rewritten pages are clearly written, well-organized with progressive disclosure (Level 1/2/3 for MOE, for example), and the migration to mkdocs-material brings a significant UX improvement. A few technical issues need addressing before merge. Issues Found🔴 Critical1. Missing
# mkdocs.yml — add this to theme.features:
- content.code.annotateThe 🟡 Moderate2.
# pyproject.toml [project.optional-dependencies] docs
"mkdocs-autorefs", # add this3. Line 8 reads: "Download Public Use Micro Sample (PUMS) data files from the US Census Bureau's FTP server." This no longer matches the library's capabilities and will appear on PyPI. It should be updated to match the new scope, e.g. "Python interface to the US Census Bureau API for ACS, Decennial Census, PUMS, estimates, and migration flows." 🟢 Minor / Polish4. Year inconsistency across examples The default year in function signatures is Affected locations:
5. County parameter note in The parameter table at # Look up the FIPS code first
from pypums.datasets import lookup_fips
fips = lookup_fips(state="California", county="Los Angeles County")
# => '06037' → pass county="037" (last 3 digits)6.
7. The In Non-Documentation Changes
Positive Highlights
|
- Add content.code.annotate feature flag to mkdocs.yml (critical) - Add mkdocs-autorefs as explicit docs dependency in pyproject.toml - Update pyproject.toml description to reflect current library scope - Align example years from 2022 to 2023 in index.md and README.md - Add lookup_fips() tip in from-tidycensus.md for county FIPS lookup - Add info admonition explaining NaN moe values in acs-data.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Claude finished @chekos's task in 1m 5s —— View job Follow-up Review: Address PR Review Feedback
All Issues from Previous Review Have Been Addressed ✅The commit "Address all PR review feedback" resolves every item flagged in the prior review. Here's a verification:
This PR is in good shape. The documentation overhaul is comprehensive and the feedback from the first review has been fully addressed. |
Summary
get_acs,get_pums,get_decennial,get_estimates,get_flows, MOE utilities, spatial support, survey design, caching, and CLIuser-guide/,history.md, andsurveys.mdthat documented only the deprecatedACS()classWhat's new
Test plan
uv run mkdocs buildcompletes with no errorsuv run mkdocs serve🤖 Generated with Claude Code