Add scope to customPredictor#813
Open
lsapan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, thanks for making this awesome library!
I realized as I was using it that when you disable dates using a customPredictor, that certain months and even years may become disabled. This is because the plugin checks the first date to see if it's disabled, rather than checking if any day in the given month/year is enabled. Makes total sense from a performance perspective in case the computation is heavy!
What I've done is simply added a second parameter to
customPredictorwhich lets us know what scope we're dealing with. So, let's say I wanted to only allow certain days of the week, I can ensure that the scope isdaybefore I say to disable the other dates. If the scope is anything else I can just always allow it.