fix: Various cable charger CBM fixes#9789
Merged
Merged
Conversation
chaosvolt
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Cable chargers, when active, can only take either their full power draw or nothing from whatever they're connected to. That means if you have a Leukocyte Breeder running (5 J/turn) and you're connected to your car with a cable charger mk2, it will draw 10 battery charges, which is 10kJ = 10000J every turn, while voiding 9995 of them. In the process of investigating it I also found some minor issues that I fixed.
(Yes, you can turn on fuel saving and auto start, but 1) you need to know to do that and it's not intuitive to have the power go into nothing and 2) it spams you with messages.)
Describe the solution (The How)
Describe alternatives you've considered
Character::find_remote_fuelworks and would like to change it, but it's consistent with other fuelled bionics.filter( null_item_reference() )check, but the only other option I could think of is to add a new parameter touse_charges, which I really don't want to do just for this incredibly specific interaction.There are some issues that I found and didn't fix:
Testing
Did some testing by connecting to vehicle/solar backpack/UPS to make sure it works. Also that regular UPS charging works.
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.Build Artifacts
PR build for commit 376f5f7 (Various cable CBM fixes) on 2026-07-03 18:14:04