feat(balance): digging, mining, and other exertion-causing activites can train athletics#9780
Draft
chaosvolt wants to merge 2 commits into
Draft
feat(balance): digging, mining, and other exertion-causing activites can train athletics#9780chaosvolt wants to merge 2 commits into
chaosvolt wants to merge 2 commits into
Conversation
…can train athletics
Contributor
|
Am I the only one who thinks there should be a cap on how much you can train athletics via mundane activities, like how laptop "train" action can get you to computers 3 max? It's already trivial to level up athletics via swimming and... existing in general. This PR will only make it easier. A manual laborer should not be on LeBron terms after swinging a pickaxe for a week or two. Past a certain point, books and specialized training equipment should come into play. Edit: It's a cool PR I just couldn't find the part when it stops training athletics eventually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
This makes several activities that call fake exertion effects at the end of the activity burn stamina along with the needs gain, thus letting them affect athletics skill.
Draft because needs #9778 to be fixed before it'll work right.
Describe the solution (The How)
Added a chunk of stamina depletion to the following functions that called
mod_fatigueand other mod functions to represent fake exertion but didn't actually burn any stamina:dig_activity_actor::finishdig_channel_activity_actor::finishactivity_handlers::burrow_finishactivity_handlers::pickaxe_finishactivity_handlers::hand_crank_do_turnactivity_handlers::train_skill_do_turnactivity_handlers::chop_tree_finishactivity_handlers::chop_logs_finishactivity_handlers::jackhammer_finishactivity_handlers::fill_pit_finishDescribe alternatives you've considered
Not adding it to
activity_handlers::train_skill_do_turnand/or limiting it so that it doesn't trigger . It seems kinda scrungly to not have your stamina visibly deplete if you're using a treadmill, but consequence is you gain slightly more athletics XP when using training items that grind athletics. Based on the EXP amounts I had after an hour of using a punching bag, athletics items will likely train athletics 12.5% faster than normal as a result of this (had 16% unarmed xp vs 2% athletics xp).Testing
Additional context
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.Build Artifacts
PR build for commit 485ffcb (Merge remote-tracking branch 'upstream/main' into lung-exploder-five-million) on 2026-07-04 02:46:47