Skip to content

feat(balance): digging, mining, and other exertion-causing activites can train athletics#9780

Draft
chaosvolt wants to merge 2 commits into
cataclysmbn:mainfrom
chaosvolt:lung-exploder-five-million
Draft

feat(balance): digging, mining, and other exertion-causing activites can train athletics#9780
chaosvolt wants to merge 2 commits into
cataclysmbn:mainfrom
chaosvolt:lung-exploder-five-million

Conversation

@chaosvolt

@chaosvolt chaosvolt commented Jul 2, 2026

Copy link
Copy Markdown
Member

Purpose of change (The Why)

This makes several activities that call fake exertion effects at the end of the activity burn stamina along with the needs gain, thus letting them affect athletics skill.

Draft because needs #9778 to be fixed before it'll work right.

Describe the solution (The How)

Added a chunk of stamina depletion to the following functions that called mod_fatigue and other mod functions to represent fake exertion but didn't actually burn any stamina:

  1. dig_activity_actor::finish
  2. dig_channel_activity_actor::finish
  3. activity_handlers::burrow_finish
  4. activity_handlers::pickaxe_finish
  5. activity_handlers::hand_crank_do_turn
  6. activity_handlers::train_skill_do_turn
  7. activity_handlers::chop_tree_finish
  8. activity_handlers::chop_logs_finish
  9. activity_handlers::jackhammer_finish
  10. activity_handlers::fill_pit_finish

Describe alternatives you've considered

Not adding it to activity_handlers::train_skill_do_turn and/or limiting it so that it doesn't trigger . It seems kinda scrungly to not have your stamina visibly deplete if you're using a treadmill, but consequence is you gain slightly more athletics XP when using training items that grind athletics. Based on the EXP amounts I had after an hour of using a punching bag, athletics items will likely train athletics 12.5% faster than normal as a result of this (had 16% unarmed xp vs 2% athletics xp).

Testing

  1. Compiled and load-tested.
  2. Dug a shallow pit, confirmed I gained 1 athletics EXP. I expect more after the bug is fixed.
  3. Used a punching bag, after an hour I had 2% athletics xp in addition to 16% unarmed xp.

Additional context

Checklist

Mandatory

Build Artifacts

PR build for commit 485ffcb (Merge remote-tracking branch 'upstream/main' into lung-exploder-five-million) on 2026-07-04 02:46:47

@github-actions github-actions Bot added the src changes related to source code. label Jul 2, 2026
@Quororque

Quororque commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Am I the only one who thinks there should be a cap on how much you can train athletics via mundane activities, like how laptop "train" action can get you to computers 3 max? It's already trivial to level up athletics via swimming and... existing in general. This PR will only make it easier. A manual laborer should not be on LeBron terms after swinging a pickaxe for a week or two. Past a certain point, books and specialized training equipment should come into play.

Edit: It's a cool PR I just couldn't find the part when it stops training athletics eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

src changes related to source code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants