Fix: preserve SendInitialEvents in ListOptions for K8s v0.36.0 compatibility#1836
Merged
sameerforge merged 2 commits intoJun 17, 2026
Merged
Conversation
…ibility Signed-off-by: Sameer <sameer.khan@broadcom.com>
Signed-off-by: Sameer <sameer.khan@broadcom.com>
Contributor
Author
Validation & Compatibility MatrixTo ensure absolute backward compatibility and stability across our support window following the
This comprehensive multi-version verification guarantees that |
praveenrewar
left a comment
Member
There was a problem hiding this comment.
Looks good mostly, could you validate this one thing and then we should be good to go.
praveenrewar
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes carvel-dev/kapp-controller/issues#1837
Summary
Fixes a 422 Unprocessable Entity validation error triggered by the upgrade to Kubernetes libraries v0.36.0+. Additionally updates golang.org/x/crypto to the latest version.
Background
The upgrade of embedded Kubernetes libraries to v0.36.0 enabled the WatchList feature gate by default. This change forces strict validation on watch requests, specifically requiring the
SendInitialEventfield to be set whenResourceVersionMatchisNotOlderThan.The Issue
The custom translation logic in the packaging API handlers was silently dropping the
SendInitialEventspointer during the conversion frominternalversion.ListOptionstometav1.ListOptions. This resulted in the K8s API server rejecting requests with a422 Unprocessable Entityerror, breaking pipelines.The Fix
SendInitialEventspointer ininternalToMetaListOptswithin both thePackageandPackageMetadataREST registry handlers. Added unit tests to verify that these options are correctly propagated to the client.Test Coverage
TestWatchListOptionsConversion(Package) ✅TestPackageMetadataWatchListOptionsConversion(PackageMetadata) ✅Validation & Compatibility Matrix
To ensure absolute backward compatibility and stability across our support window following the
v0.36.0library upgrades, the complete test suite (Unit, Validation, and E2E integration tests) was successfully executed against the following Kubernetes environments:test-gh / Run all testsv1.32.13test-gh / Run all testsv1.33.12test-gh / Run all testsv1.34.8test-gh / Run all testsv1.35.5test-gh / Run all testsv1.36.1Kind Cluster E2E testskinder)v1.36.xThis comprehensive multi-version verification guarantees that
kapp-controllersafely supports legacy enterprise baselines while remaining completely ready for cutting-edge nativev1.36control planes.