fix: prevent toCalendarSystem() from mutating global locale state#19
Merged
Conversation
The instance method toCalendarSystem() was incorrectly calling dayjsFactory.updateLocale() which mutated the global locale dictionary. This caused all subsequent dayjs instances to use the calendar-specific month names, making it impossible to use multiple calendar systems simultaneously. Changes: - Remove global updateLocale() call from instance toCalendarSystem() - Store calendar-specific locale data on instance ($calendarLocale) - Override $locale() to merge instance-specific locale when available - Update locale() to regenerate $calendarLocale when locale changes Fixes #18
Contributor
|
✅ All CI checks have passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instance method toCalendarSystem() was incorrectly calling dayjsFactory.updateLocale() which mutated the global locale dictionary. This caused all subsequent dayjs instances to use the calendar-specific month names, making it impossible to use multiple calendar systems simultaneously.
Changes:
Fixes #18