Skip to content

Revert "Docker: pass Options.platform to inspect and default local platform to linux/$GOARCH"#303

Merged
jabrown85 merged 3 commits into
mainfrom
revert-302-l1599-local-platform
Feb 16, 2026
Merged

Revert "Docker: pass Options.platform to inspect and default local platform to linux/$GOARCH"#303
jabrown85 merged 3 commits into
mainfrom
revert-302-l1599-local-platform

Conversation

@jabrown85

Copy link
Copy Markdown
Contributor

Reverts #302

FYI @bojidar-bg - Reported buildpacks/lifecycle#1605. We can regroup on this if you'd like sometime.

@jabrown85
jabrown85 requested a review from a team as a code owner February 13, 2026 15:30
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
@jabrown85
jabrown85 enabled auto-merge February 13, 2026 16:23
@jabrown85

Copy link
Copy Markdown
Contributor Author

@bojidar-bg this test failure on lifecycle is the test that I think we'll need to fix to bring this back. This is on a run post-GHA change with some imgutil patches but still with your changes.

Now that the GitHub runner is on containerd-snapshotter for docker - it fails like this.

== NAME  TestCreator/acceptance-creator/0.7/daemon_case/creates_app
    creator_test.go:110: Expected nil: failed to execute command: [docker run --rm --mount type=bind,source=/var/run/docker.sock,target=/var/run/docker.sock --user 0 --env CNB_PLATFORM_API=0.7 --env CNB_REGISTRY_AUTH={"localhost:39187":"Basic YW9obmhnbGlybjplcWdnaGd2bHhu"} --network host lifecycle/acceptance/creator /cnb/lifecycle/creator -daemon -run-image localhost:39187/some-read-only-run-image-zfjcgidlkd some-created-image-yzegflzgvg], exit status 62, , Warning: No cached data will be used, no cache specified.
        ===> ANALYZING
        **Docker did not find image some-created-image-yzegflzgvg with platform linux/amd64; retrying without specifying a platform**
        Image with name "some-created-image-yzegflzgvg" not found
...
        Saving some-created-image-yzegflzgvg...
        ERROR: failed to export: saving image: failed to fetch base layers: saving image with ID "sha256:53f0fe83f1853effee73137d1ce8a47178abb6f434508e3fa2ae08a391c0ec89" from the docker daemon: Error response from daemon: No such image: sha256:53f0fe83f1853effee73137d1ce8a47178abb6f434508e3fa2ae08a391c0ec89

I'm not sure why this seemingly failed on linux/amd64 but passed on linux/arm64 either...

@bojidar-bg

bojidar-bg commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

Hm... I have seen that particular "failed to fetch base layers" error a few times with linux/arm64, but assumed it wasn't related to the imgutils change, but was some odd Docker bug (case in point: after pulling X with digest H and getting the issue, I recall being able to work around the issue by pulling X@H explicitly.).
I'll investigate this over the week and see if I can get a better understanding of what's going on -- feel free to revert in the meantime, so we don't force people to downgrade.

@jabrown85
jabrown85 merged commit 65b01ef into main Feb 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants