fix: keep restore TUI within terminal bounds (closes #125)#127
Merged
Conversation
8d2e542 to
c8e386b
Compare
Contributor
Code Metrics Report
Details | | main (4f189da) | #127 (a6d1395) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 71.2% | 71.2% | 0.0% |
| Files | 24 | 24 | 0 |
| Lines | 1101 | 1101 | 0 |
| Covered | 784 | 784 | 0 |
+ | Code to Test Ratio | 1:1.5 | 1:1.5 | +0.0 |
| Code | 2739 | 2739 | 0 |
+ | Test | 4216 | 4280 | +64 |
+ | Test Execution Time | 28s | 6s | -22s |Reported by octocov |
Merged
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jun 10, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [babarot/gomi](https://github.com/babarot/gomi) | patch | `v1.6.3` β `v1.6.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>babarot/gomi (babarot/gomi)</summary> ### [`v1.6.4`](https://github.com/babarot/gomi/blob/HEAD/CHANGELOG.md#v164---2026-06-07) [Compare Source](babarot/gomi@v1.6.3...v1.6.4) ##### Improvements - fix: keep restore TUI within terminal bounds (closes [#​125](babarot/gomi#125)) by [@​babarot](https://github.com/babarot) in [#​127](babarot/gomi#127) - Allow --prune to skip confirmation with -f by [@​babarot](https://github.com/babarot) in [#​129](babarot/gomi#129) ##### Refactorings - Fix concurrency safety: eliminate global SelectionManager and add mutex to legacy Storage by [@​babarot](https://github.com/babarot) in [#​118](babarot/gomi#118) - Refactor: extract Trash interface, move orphan logic, and DRY up XDG storage by [@​babarot](https://github.com/babarot) in [#​119](babarot/gomi#119) - Refactor: decouple config, remove unused fields, and narrow UI dependencies by [@​babarot](https://github.com/babarot) in [#​120](babarot/gomi#120) - Update architecture docs and rename manager variables to match Trash interface by [@​babarot](https://github.com/babarot) in [#​121](babarot/gomi#121) - Fix fundamental design issues: circular references, untestable prompts, and implicit init() by [@​babarot](https://github.com/babarot) in [#​122](babarot/gomi#122) - Reduce syscalls in gomi -b restore path by [@​babarot](https://github.com/babarot) in [#​123](babarot/gomi#123) </details> --- ### Configuration π **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) π¦ **Automerge**: Enabled. β» **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. π **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOTEuMiIsInVwZGF0ZWRJblZlciI6IjQzLjE5MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6cGF0Y2giXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Adjust the restore TUI to follow the actual terminal size on
WindowSizeMsg. The list height now shrinks to fit, the help row is told the terminal width so bubbles can truncate it, and width-only resize messages no longer collapse the list.WHY
Reported in #125: in small terminals the
gomi --restoreview broke. The list items were pushed off the top because the list kept its default 30-row height, and the short-help row overflowed the terminal width and wrapped mid-word.The
WindowSizeMsghandler ininternal/ui/update.goonly calledm.list.SetWidth(msg.Width). The height was never updated andm.help.Widthwas left at 0, so the help model could not truncate its output.A naive fix (always derive list height from
msg.Height) introduces a regression: the confirm-view cancel paths inupdateConfirmViewsend a synthetictea.WindowSizeMsg{Width: m.list.Width()}withHeight == 0, which would collapse the list to 1 row every time the user dismisses the confirm dialog. The fix therefore guards each dimension independently.HOW
internal/ui/update.go: in thetea.WindowSizeMsgbranch, update width and height only when the corresponding field is positive. The list is sized viaSetWidth/SetHeight, reserving 3 rows and 4 columns for the help block thatview.gorenders below the list withlipgloss.Margin(1, 2). The reserved values are declared as named constants with a comment that points back to the layout inview.goso the magic numbers are traceable.internal/ui/update_test.go: add regression tests covering the small-terminal scenarios.TestUpdate_WindowSizeMsg_ShrinksListHeightandTestUpdate_WindowSizeMsg_SetsHelpWidthassert the list and help shrink to fit.TestView_FitsSmallTerminalis an end-to-end check thatModel.View()does not exceed the requested terminal width and height.TestUpdate_WindowSizeMsg_HeightZeroguards against the confirm-cancel synthetic message: after a real resize, a width-only message must not change the list height.The patch attached to #125 by @u1f992 was used as the starting point; the height-zero guard and accompanying test were added on top to avoid the confirm-cancel regression.