Add Japanese translation with path-prefix locale routing#23
Merged
Conversation
Set up path-prefix locale routing (/ja/...) with optional locale scope for public routes. Auth and admin routes remain outside the scope. Add set_locale and default_url_options to ApplicationController. Configure available_locales [:en, :ja] and set HTML lang attribute.
…tcher Extract duplicated footer into shared _footer.html.erb partial. Internationalize navigation and footer strings with t() helpers. Add EN/日本語 language switcher to desktop and mobile navigation. Fix hardcoded href="/" links to use root_path for locale awareness. Use current_page? helper for active link detection.
Extract ~200 hardcoded English strings from all 4 public pages into t() helper calls with nested YAML locale files per view. Handle JS progress text in checklist controller via Stimulus value. Restore shared footer partial renders that worktree agents reverted.
Generate ja.yml translations for navigation, footer, and all 4 public pages (home, organizer guide, checklist, stamp samples). Proper nouns, interpolation variables, and HTML markup preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/ja/...for Japanese,/for English)t()helpersContext
The site will be used at an upcoming Japanese Ruby event. Japanese-speaking attendees need the content in their language.
Key decisions
/ja/) over subdomain — simpler, no DNS configTest plan
/and/ja/URLsPost-Deploy Monitoring & Validation
/ja/pages render without missing translation errors