[mono-move] Small benchmark improvements#20158
Open
georgemitenkov wants to merge 1 commit into
Open
Conversation
ccc76c8 to
abac4eb
Compare
Contributor
mono-move benchmark gate1 regression(s) beyond ±3% noise band
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Ability to benchmark 1 VM at a time via
--vm (both } v1 | v2)flags.How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist
Note
Low Risk
Changes are limited to the mono-move replay-benchmark developer tool and default behavior remains both VMs; no validator or production VM paths are affected.
Overview
Adds a
--vmCLI option (v1,v2, orboth, defaultboth) so the replay benchmark can run only the legacy Move VM or only MonoMove—useful for profiling one VM without the other in the same process.Reporting now treats each VM result as optional: skipped VMs print as
skipped, and speedup/correctness lines are omitted unless both VMs ran.The README documents benchmarking a single transaction via
--transactions-file/--inputs-fileand gives a samply example with--vm v1. Two TODO comments in the V2 harness flag possible missing reset of events/extensions between timed iterations (no behavior change in this PR).Reviewed by Cursor Bugbot for commit abac4eb. Bugbot is set up for automated code reviews on this repo. Configure here.