refactor(@angular/cli): implement native stream line-buffering & VT removal for MCP logs#33210
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors log handling in the MCP devserver and host by replacing raw stream data listeners with the node:readline interface for line-by-line processing. The changes include stripping VT control characters and trimming log lines. Corresponding updates were made to the test suite to include line terminators in mock data. Review feedback suggests deduplicating the stream processing logic, removing redundant carriage return replacements already handled by readline, and using .trimEnd() instead of .trim() to preserve important log indentation.
…emoval for MCP logs Refactor the process log capturing mechanism in host.ts and devserver.ts to natively line-buffer and sanitize process stdout and stderr streams using Node's native readline `createInterface` API and `util.stripVTControlCharacters`. This ensures all command and devserver logs are cleanly line-split, trimmed, and stripped of VT/ANSI color sequences and carriage returns.
254808a to
0a42691
Compare
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Refactor the process log capturing mechanism in host.ts and devserver.ts to natively line-buffer and sanitize process stdout and stderr streams using Node's native readline
createInterfaceAPI andutil.stripVTControlCharacters. This ensures all command and devserver logs are cleanly line-split, trimmed, and stripped of VT/ANSI color sequences and carriage.