Fix #90 assertion error stacktrace's and upgrades dependencies#91
Open
vrescobar wants to merge 2 commits into
Open
Fix #90 assertion error stacktrace's and upgrades dependencies#91vrescobar wants to merge 2 commits into
vrescobar wants to merge 2 commits into
Conversation
fix alexmercerind#90 This commit addresses two issues reported in [alexmercerind#90](alexmercerind#90): - Clamp titlebar height to non-negative values in TitlebarSafeArea to prevent assertion errors from negative padding when resizing the window on macOS. - Add checks for RenderObject attachment and widget mounting in VisualEffectSubviewContainerWithGlobalKey to prevent assertion errors when accessing layout information after widget disposal or detachment. These changes ensure robust handling of window resizing and widget lifecycle, preventing runtime exceptions on macOS 14.5 and improving stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It solves a stacktrace error on the console caused by an assertion error regarding the padding.
I also took the time to upgrade dependencies, fix warnings and refactor deprecated methods.