Skip to content

🐛 Update now-defunct go.usa URL to NHC direct#1218

Merged
akrherz merged 1 commit into
mainfrom
nhc_links
Jun 9, 2026
Merged

🐛 Update now-defunct go.usa URL to NHC direct#1218
akrherz merged 1 commit into
mainfrom
nhc_links

Conversation

@akrherz

@akrherz akrherz commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Updated NHC website link in product output to use a functional URL.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: af61ffa8-fde2-48a1-866d-89435d59a3d4

📥 Commits

Reviewing files that changed from the base of the PR and between ee98fda and 2cc7590.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • src/pyiem/nws/products/nhc.py
  • tests/nws/test_products.py

📝 Walkthrough

Walkthrough

This PR replaces a defunct URL shortener (go.usa.gov/W3H) with a direct NOAA link (https://www.nhc.noaa.gov/#%(storm_name)s) in NHC product jabber/tweet generation, updates the corresponding test assertion, and documents the fix in the changelog.

Changes

NHC URL Update

Layer / File(s) Summary
NHC URL update from defunct shortener to direct NOAA link
src/pyiem/nws/products/nhc.py, tests/nws/test_products.py, CHANGELOG.md
The NHCProduct.get_jabbers template URL changes from http://go.usa.gov/W3H to https://www.nhc.noaa.gov/#%(storm_name)s. The test expectation in test_tcp is updated to reflect the new URL. The changelog documents the URL update as a bug fix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A shortened link broke on the way,
So we swapped it for NOAA's display,
From go.usa.gov we did flee,
To nhc.noaa.gov — direct and free!
Tests and docs all align,
Now hurricane forecasts shine! 🌀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: replacing a defunct URL shortener with a direct NHC link across the codebase.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nhc_links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deepsource-io

deepsource-io Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

DeepSource Code Review

We reviewed changes in ee98fda...2cc7590 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Jun 9, 2026 6:49p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (ee98fda) to head (2cc7590).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          92       92           
  Lines       10912    10912           
=======================================
  Hits        10764    10764           
  Misses        148      148           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akrherz akrherz merged commit 581491d into main Jun 9, 2026
10 checks passed
@akrherz akrherz deleted the nhc_links branch June 9, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant