Skip to content

replace async-timeout with asyncio.timeout#232

Open
dotlambda wants to merge 2 commits into
aiokitchen:masterfrom
dotlambda:async-timeout
Open

replace async-timeout with asyncio.timeout#232
dotlambda wants to merge 2 commits into
aiokitchen:masterfrom
dotlambda:async-timeout

Conversation

@dotlambda

Copy link
Copy Markdown

No description provided.

@mosquito

Copy link
Copy Markdown
Collaborator

Hi @dotlambda, could you please explain what exactly problem you're solving with this PR? I don't understand why we should drop support for Python 3.10, whose EoL is in a year. If you don't mind, perhaps we could wait with merging until then.

@dotlambda

Copy link
Copy Markdown
Author

I'm just trying to follow upstream's recommendation.

We could also use

if sys.version_info >= (3, 11):
    from asyncio import timeout
else:
    from async_timeout import timeout

@mosquito

Copy link
Copy Markdown
Collaborator

It was a dev dependency, needed only for tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants