Skip to content

Add support for Deezer#11

Open
aghontpi wants to merge 4 commits into
masterfrom
support-Deezer
Open

Add support for Deezer#11
aghontpi wants to merge 4 commits into
masterfrom
support-Deezer

Conversation

@aghontpi

@aghontpi aghontpi commented Dec 30, 2021

Copy link
Copy Markdown
Owner

This pr should extend support for Deezer android app

link: https://play.google.com/store/apps/details?id=deezer.android.app

closes #11

@aghontpi

Copy link
Copy Markdown
Owner Author

block deezer ads

@aghontpi

aghontpi commented Dec 30, 2021

Copy link
Copy Markdown
Owner Author

the following build will add support for Deezer. (Due to location restrictions in app, I can only run it on an android emulator.)

Will test it for a couple days before merging to master.

(rename .zip to .apk, restrictions in github comments)
ad-silence-test-build-7.zip @Cwpute in #10 tested this did not work.
Build 10 is just making sure the build has all the changes and a notification fix that is unrelated to Deezer.
ad-silence-test-build-10.zip

@aghontpi

aghontpi commented Jan 1, 2022

Copy link
Copy Markdown
Owner Author

while testing... bugs have been reported

  • did not work on Deezer (different android device other than mine)

so until that is verified and fixed, this will not be merged.

@unseenlarks

Copy link
Copy Markdown

i'm not a developer, just use your app but am also a Deezer user. so for what it's worth if i can test anything (on Android 8), let me know.

@aghontpi

aghontpi commented Mar 9, 2022

Copy link
Copy Markdown
Owner Author

@unseenlarks nice!

the following build will add support for Deezer. (Due to location restrictions in app, I can only run it on an android emulator.)

Will test it for a couple days before merging to master.

(rename .zip to .apk, restrictions in github comments) ad-silence-test-build-7.zip @Cwpute in #10 tested this did not work. Build 10 is just making sure the build has all the changes and a notification fix that is unrelated to Deezer. ad-silence-test-build-10.zip

can you test this build for now?

@unseenlarks

Copy link
Copy Markdown

i've just tried to install it but my phone won't have it (even when allowed to install from unknown/third-party sources as i normally would).

@aghontpi

aghontpi commented Mar 11, 2022

Copy link
Copy Markdown
Owner Author

@unseenlarks, it might be because of build version, test with the new build below.

I merged it with upstream & fixed conflicts.

if you have previous versions installed from Playstore or Fdroid, uninstall it first before installing this.

(rename .zip to .apk, due to restrictions in github comments)
ad-silence-test-build-27.zip

@unseenlarks

Copy link
Copy Markdown

still having the same issue unfortunately. my phone won't install this .apk either.

@aghontpi

Copy link
Copy Markdown
Owner Author

if you have previous versions installed from Playstore or Fdroid, uninstall it first before installing this.

(rename .zip to .apk, due to restrictions in github comments) ad-silence-test-build-27.zip

could you try this?

@unseenlarks

Copy link
Copy Markdown

thank you, clearly i should have tried that first. finally installed the above build, but unfortunately ads aren't blocked/detected.

Ad-silence has been granted notification access and is enabled to mute ads. Deezer is enabled under 'select apps', and the Ad-silence notification is always visible on the notification drawer. battery optimisation has been disabled for Ad-silence.

when ads are playing, the Ad-silence notification displays 'listening for ads', same as when actual music is playing, or when Deezer itself is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants