Survey accounts translation issues by GeorgeMurad · Pull Request #10697 · aces/Loris

GeorgeMurad · 2026-06-26T15:03:31Z

French language was missing under the survey accounts module.

Testing instructions (if applicable)

Steps to regenerate and verify locally:

msgfmt --use-fuzzy \
  -o modules/survey_accounts/locale/fr_CA/LC_MESSAGES/survey_accounts.mo \
  modules/survey_accounts/locale/fr_CA/LC_MESSAGES/survey_accounts.po
npx i18next-conv \
  -l UNUSED \
  -t modules/survey_accounts/locale/fr_CA/LC_MESSAGES/survey_accounts.json \
  -s modules/survey_accounts/locale/fr_CA/LC_MESSAGES/survey_accounts.po \
  --compatibilityJSON v4
target=survey_accounts npm run compile

Make sure the language_code fr_CA is added to the language table.
Test the French language under the Survey Accounts module.

Link(s) to related issue(s)

[survey_accounts] Some Untranslated Parts In The Survey Accounts Module #10575

HachemJ · 2026-06-30T18:17:30Z

I am not sure how to include it in terms of code review on GitHub but I would suggest to also change the french locale directory name from fr_CA to fr for the same reason as my previous review comments.

GeorgeMurad · 2026-06-30T18:19:18Z

Yes make sense, I will update it soon. Thanks!

HachemJ · 2026-06-30T18:34:53Z

                return ['Email' => dgettext(
                    'survey_accounts',
-                    'Email is not valid.'
+                    'The email address is not valid.'


I agree with the change but it implies the following line in the hindi locale to be changed since it uses the old version of the string 'Email is not valid.'

GeorgeMurad · 2026-06-30T18:38:43Z

let me know when you finish reviewing as I am currently updating the PR.

HachemJ · 2026-06-30T18:59:34Z

let me know when you finish reviewing as I am currently updating the PR.

@GeorgeMurad I will. It's not done yet but you can start changing some stuff I already mentioned if you agree.

HachemJ · 2026-06-30T19:28:40Z

            )
        );
-        $this->addBasicText("Email", "Email address");
+        $this->addBasicText("Email", dgettext('survey_accounts', 'Email address'));


I would suggest this change

Suggested change

$this->addBasicText("Email", dgettext('survey_accounts', 'Email address'));

$this->addBasicText("Email", dgettext('loris', 'Email address'));

Same reason as https://github.com/aces/Loris/pull/10697/changes#r3501043380

If you do, please remove Email address from this module's french locale as well as the .pot file since it will be using the loris namespace that already has the translations.

HachemJ · 2026-06-30T19:33:42Z

+            'Created'     => dgettext("survey_accounts", "Created"),
+            'Sent'        => dgettext("survey_accounts", "Sent"),
+            'In Progress' => dgettext("survey_accounts", "In Progress"),
+            'Complete'    => dgettext("survey_accounts", "Complete"),


I suggest reverting for the same reason.

Suggested change

'Created' => dgettext("survey_accounts", "Created"),

'Sent' => dgettext("survey_accounts", "Sent"),

'In Progress' => dgettext("survey_accounts", "In Progress"),

'Complete' => dgettext("survey_accounts", "Complete"),

'Created' => dgettext("loris", "Created"),

'Sent' => dgettext("loris", "Sent"),

'In Progress' => dgettext("loris", "In Progress"),

'Complete' => dgettext("loris", "Complete"),

If you do revert, all 4 to remove from the module's french locale as well as the .pot file of that module.

HachemJ · 2026-06-30T19:36:21Z

+        $this->addBasicText("CandID", dgettext('survey_accounts', 'DCCID'));
+        $this->addBasicText("PSCID", dgettext('survey_accounts', 'PSCID'));
+        $this->addSelect(
+            "VL",
+            dgettext('survey_accounts', 'Visit Label'),


Suggested change

$this->addBasicText("CandID", dgettext('survey_accounts', 'DCCID'));

$this->addBasicText("PSCID", dgettext('survey_accounts', 'PSCID'));

$this->addSelect(

"VL",

dgettext('survey_accounts', 'Visit Label'),

$this->addBasicText("CandID", dgettext('loris', 'DCCID'));

$this->addBasicText("PSCID", dgettext('loris', 'PSCID'));

$this->addSelect(

"VL",

dgettext('loris', 'Visit Label'),

If you do revert, all 3 (DCCID, PSCID and Visit Label) to remove from the module's french locale as well as the .pot file of that module.

HachemJ · 2026-06-30T19:37:18Z

            "Test_name",
-            "Instrument",
+            dcngettext(
+                'survey_accounts',


This should be changed if you apply my suggestions on removing Instrument from this module's locale translation files.

Suggested change

'survey_accounts',

'loris',

HachemJ · 2026-06-30T19:37:46Z

                return [
-                    'Test_name' => "Instrument ".
+                    'Test_name' => dcngettext(
+                        'survey_accounts',


This should be changed if you apply my suggestions on removing Instrument from this module's locale translation files.

Suggested change

'survey_accounts',

'loris',

GeorgeMurad · 2026-06-30T19:42:15Z

Please review again, and let me know what is still missing, thanks a lot!

HachemJ · 2026-06-30T19:42:47Z

                return ['Email' => dgettext(
                    'survey_accounts',
-                    'The email address is not valid.'
+                    'Email is not valid.'


You might still be making changes but make sure in the case where you keep that version to omit every instance of 'The email address is not valid.' for example still present in all of these files (after pulling your latest commit 'apply new updates')

Also not sure if you should be using single or double quotes for these.

HachemJ · 2026-06-30T19:44:58Z

Please review again, and let me know what is still missing, thanks a lot!

@GeorgeMurad I just finished please check the latest changes I suggested and I will re review when you are ready. I checked your latest commit 'apply new updates' and there are still some things missing.

HachemJ · 2026-06-30T19:46:06Z

    echo json_encode(
        [
-            'error_msg' => dgettext('loris', 'Visit').' '. $_REQUEST['VL'].' '.
+            'error_msg' => dgettext('survey_accounts', 'Visit').' '.


Same reason as previous comments.

Suggested change

'error_msg' => dgettext('survey_accounts', 'Visit').' '.

'error_msg' => dgettext('loris', 'Visit').' '.

GeorgeMurad · 2026-06-30T19:46:11Z

Great, I will make the changes soon.

HachemJ · 2026-06-30T19:47:07Z

-                'error_msg' => dgettext('loris', 'Instrument').' '. $_REQUEST['TN']
-                .' ' .dgettext(
+                'error_msg' => dcngettext(
+                    'survey_accounts',


Same reason as previous comments.

Suggested change

'survey_accounts',

'loris',

George Murad added 4 commits June 26, 2026 10:56

[survey_accounts]Add French Language To Survey Accounts

30b999b

add the json file

3182174

lint error

f313af3

eslint error

fe6eedb

github-actions Bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: survey_accounts PR or issue related to the survey_accounts module Multilingual Any tasks related to making LORIS multilingual labels Jun 26, 2026

GeorgeMurad mentioned this pull request Jun 26, 2026

[survey_accounts]Add French Language To Survey Accounts #10696

Closed

1 task

GeorgeMurad added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jun 29, 2026

driusan changed the title ~~Survey accunts translation issues~~ Survey accounts translation issues Jun 29, 2026

CamilleBeau assigned HachemJ Jun 29, 2026