[JS] Split form and non-form modals and support custom modal footers#10695
Draft
MaximeBICMTL wants to merge 2 commits into
Draft
[JS] Split form and non-form modals and support custom modal footers#10695MaximeBICMTL wants to merge 2 commits into
MaximeBICMTL wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the LORIS modal to make two major changes:
Architecture
Modalcomponent fromjsx/Modals.tsxis split into three components:Modal: The general non-form modal, which allows the consumer to provide the body and optionally the footer.FormModal: The form modal, which is similar to the current modal and provides form and submit logic/controls.ModalFrame: common architecture between the two modals, technicallyFormModalcould also be made to depend directly uponModalbut this would require some higher-order component machinery because the form body and content should both be wrapper in aformelement, and this wrapper is undesirable in the general case.Examples
[TODO: provide videos]