Skip to content

[data_release] Fixes issue where users able to upload files to projects they do not have access to.#10692

Merged
CamilleBeau merged 2 commits into
aces:29.0-releasefrom
racostas:2026_06_25_data_release_fix_uploading_to_not_accessible_project
Jun 29, 2026
Merged

[data_release] Fixes issue where users able to upload files to projects they do not have access to.#10692
CamilleBeau merged 2 commits into
aces:29.0-releasefrom
racostas:2026_06_25_data_release_fix_uploading_to_not_accessible_project

Conversation

@racostas

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Modifies modules/data_release/php/data_release.class.inc to only show the projects the user have access in the SelectBox.
  • Modifies modules/data_release/php/files.class.inc to check the user have access to the project before allowing the insertion.

Testing instructions (if applicable)

  1. Go to 'data_release' with a user affiliated only to certain projects.
  2. Click on 'upload file'
  3. Click on 'project
  4. Note that only the projects the user have access to are listed.
data_release_projects_ok
  1. Try to upload a file and checks it properly uploads.
  2. Try to change to another user and please repeat steps 1 to 5.
  3. The rest of the functionalities should remain unchanged.

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Module: data_release PR or issue related to data_release module labels Jun 25, 2026
@racostas racostas added 29.0.0 - Bugs Issues found during the release testing for 29.0.0 Critical to release PR or issue is key for the release to which it has been assigned Module: data_release PR or issue related to data_release module State: Needs work PR awaiting additional work by the author to proceed and removed Language: PHP PR or issue that update PHP code Module: data_release PR or issue related to data_release module labels Jun 25, 2026
@racostas

Copy link
Copy Markdown
Contributor Author

I will be fixing the code formatting ...

@github-actions github-actions Bot added the Language: PHP PR or issue that update PHP code label Jun 25, 2026
@racostas racostas removed the State: Needs work PR awaiting additional work by the author to proceed label Jun 25, 2026
@racostas racostas requested a review from lapadulamichael June 25, 2026 18:16

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lapadulamichael lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jun 26, 2026
@CamilleBeau CamilleBeau merged commit ad3095c into aces:29.0-release Jun 29, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Critical to release PR or issue is key for the release to which it has been assigned Language: PHP PR or issue that update PHP code Module: data_release PR or issue related to data_release module Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants