Skip to content

[survey_accounts] Add Space For The Validation Message#10683

Merged
driusan merged 1 commit into
aces:29.0-releasefrom
GeorgeMurad:SurveyAccountsIssues
Jun 30, 2026
Merged

[survey_accounts] Add Space For The Validation Message#10683
driusan merged 1 commit into
aces:29.0-releasefrom
GeorgeMurad:SurveyAccountsIssues

Conversation

@GeorgeMurad

@GeorgeMurad GeorgeMurad commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Add space on the validation error message.

trsting the fix:

  1. Go to 'survey_accounts'
  2. Click on 'Add Survey'
  3. Choose: DCCID: 2361712077, PSCID: DCC0703, Visit Label: V1 and Instument: BMI Calculator
  4. See the error message is missing a space between the instrment name and the word "already"
  5. Fix: Instrument BMI Calculator already exists for the given candidate for visitV1

Related to: #10562

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Module: survey_accounts PR or issue related to the survey_accounts module labels Jun 22, 2026
@GeorgeMurad GeorgeMurad added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jun 22, 2026
@GeorgeMurad GeorgeMurad changed the title Add space [survey_accounts] Add Space For The Validation Message Jun 22, 2026
@CamilleBeau CamilleBeau added the Critical to release PR or issue is key for the release to which it has been assigned label Jun 29, 2026
@lapadulamichael lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jun 30, 2026
lapadulamichael
lapadulamichael approved these changes Jun 30, 2026
View reviewed changes

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@driusan driusan merged commit 80933df into aces:29.0-release Jun 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lapadulamichael lapadulamichael lapadulamichael approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lapadulamichael lapadulamichael

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Critical to release PR or issue is key for the release to which it has been assigned Language: PHP PR or issue that update PHP code Module: survey_accounts PR or issue related to the survey_accounts module Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GeorgeMurad @lapadulamichael @driusan @CamilleBeau