[instrument_manager] Page count fix#10655
Merged
driusan merged 9 commits intoJun 30, 2026
Merged
Conversation
github-actions
Bot
added
the
Language: Javascript
fias06
force-pushed
the
2026_06_18_fix_instrument_manager_page_count
branch
from
db2f811 to
eee4518
Compare
added 3 commits
June 18, 2026 15:52
fias06
force-pushed
the
2026_06_18_fix_instrument_manager_page_count
branch
from
1fbc053 to
48454e0
Compare
fias06
added
Module: instrument_manager
lapadulamichael
suggested changes
Jun 26, 2026
lapadulamichael
left a comment
lapadulamichael
left a comment
Contributor
There was a problem hiding this comment.
I would suggest simply adding import i18n from 'I18nSetup'; to instrumentManagerIndex.js instead of changing DataTable.js
lapadulamichael
added
the
State: Needs work
added 2 commits
June 29, 2026 15:44
fias06
removed
the
State: Needs work
driusan
reviewed
Jun 29, 2026
added 2 commits
June 29, 2026 16:11
lapadulamichael
added
the
Passed manual tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Fixed the page count on instrument manager
Testing instructions (if applicable)
Link(s) to related issue(s)