Fmt attr fix#168
Merged
Merged
Conversation
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
We use the 'format' function attribute on the _logger() function to do checking of the specified arguments against the specified format. However this was actually working, i.e. no warning was being generated when specifying incorrect arguments. The attribute needs to be associated with the function prototype, or the function definition iff there isn't a separate prototype, which is where it was being specified. However there is a function prototype for _logger() in a header file and that is where we need to specify the function attribute. With this the compiler now provides the desired warnings. Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
There was a problem hiding this comment.
Pull request overview
This PR updates the logger API to enable compiler printf-style format checking via a function attribute, and adjusts the project’s version “PLUS” suffix.
Changes:
- Move the GCC/Clang
format(printf, ...)attribute from_logger()’s definition into its prototype inlogger.h. - Update copyright headers to 2026.
- Set
PLUSinversion.mkto+.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
version.mk |
Changes version suffix used to construct build/version strings. |
src/logger.h |
Adds format(printf, 3, 4) attribute to _logger() declaration for format checking. |
src/logger.c |
Removes the format attribute from the _logger() definition (now declared in header). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.