feat: add Objective-C ingestion support (phase 1)#1882
Draft
call-me-sean wants to merge 2 commits into
Draft
Conversation
|
Someone is attempting to deploy a commit to the NexusCore Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
gitnexus/src/core/ingestion/languages/objc.tsSupportedLanguages.ObjectiveC.m,.mmNS_ASSUME_NONNULL_BEGIN/END) to preserve parser stabilitytree-sitter-objcwired inparser-loader.tstree-sitter-queries.tstest/fixtures/sample-code/simple.mtest/integration/tree-sitter-languages.test.tsDependency note
tree-sitter-objc@^2.1.0tree-sitter@0.21.x;tree-sitter-objc@3.xpulls peerOptionaltree-sitter@^0.22.1, causing install conflict in this branch setupValidation
Follow-ups (separate phase)
Incremental update
Additional follow-up has now been pushed on branch
feat/objcxx-p2-02-header-classification:f3ad5c21fix(objcxx): honor guarded ObjC and C++ header signalsWhat this follow-up fixes:
.h/.pchclassification now inspects compatibility-guarded branches__OBJC__sections contribute Objective-C signals__cplusplussections contribute C++ signalsobjcGuardedSignalscppGuardedSignalsWhy it matters:
Validation:
node gitnexus/scripts/build.jscd gitnexus && npx vitest run test/unit/ingestion-utils.test.ts test/unit/sequential-language-availability.test.ts