feat(cli): add system onnxruntime-node binding override#1526
Open
PieterPel wants to merge 1 commit into
Open
Conversation
|
@PieterPel is attempting to deploy a commit to the NexusCore Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the system ONNX Runtime binding override support discussed in PR #589, updated for current
mainby keeping only the still-relevant pieces. This allows GitNexus to use a system-providedonnxruntime_binding.nodeviaGITNEXUS_ORT_BINDING_PATH, and wires it into both embedder entry points.Motivation / context
This is a follow-up to the closed PR: #589
Maintainer requested a fresh PR if still relevant. Since upstream already added the HF cache-dir work, this PR only carries forward the ONNX binding override part that remains missing.
Areas touched
gitnexus/(CLI / core / MCP server)gitnexus-web/(Vite / React UI).github/(workflows, actions)eval/or other toolingAGENTS.md,CLAUDE.md,.cursor/,llms.txt, etc.)Scope & constraints
In scope
onnxruntime_binding.nodeto a user-specified absolute path.gitnexus/src/core/embeddings/embedder.tsgitnexus/src/mcp/core/embedder.tsgitnexus/README.mdunder “System ONNX Runtime Binding (Advanced)”.Explicitly out of scope / not done here
Implementation notes
onnxruntime_binding.node.GITNEXUS_ORT_BINDING_PATHis absolute and exists before applying override.Testing & verification
cd gitnexus && npm testcd gitnexus && npm run test:integration(if core/indexing/MCP paths changed)cd gitnexus && npx tsc --noEmitcd gitnexus-web && npm test(if web changed)cd gitnexus-web && npx tsc -b --noEmit(if web changed)gitnexus-web/e2e/)Commands run
Notes on results
npx tsc --noEmit: passed.npm testrun in container reports existing unrelated failures in this environment.pipeline-graph-goldenwas initially failing due fixture pollution (AGENTS.md,CLAUDE.md,.gitignore) and now passes after cleaning fixture files.mcp/server-startupfailure reproduces onupstream/mainin this environment too (native@ladybugdb/coreload issue), indicating it is not introduced by this PR.Risk & rollout
GITNEXUS_ORT_BINDING_PATHis unset.Checklist
AGENTS.md/ overlays changed: headers, scope block, and changelog updated per project conventions