Fix off-by-one error in status lists#12
Open
nodh wants to merge 1 commit into
Open
Conversation
JesusMcCloud
requested changes
Jun 26, 2026
| return List(maxRevocationListIndex.toInt()) { listIndex -> | ||
| // Revocation list indexes are 1-based, so the list needs `maxRevocationListIndex + 1` entries | ||
| // for the credential at the highest index (e.g. the one just issued) to be included and reported as valid. | ||
| return List(maxRevocationListIndex.toInt() + 1) { listIndex -> |
Contributor
There was a problem hiding this comment.
add a check that this does not exceed Int.MAX_VALUE (or any other, much more sensible lower guard) like so: require(maxRevocationListIndex + 1 <Int.MAX_VALUE) {"Revocation list too large"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.