Conversation
WenzDaniel
approved these changes
Jan 27, 2026
dachengx
requested changes
Jan 27, 2026
dachengx
approved these changes
Jan 27, 2026
Pull Request Test Coverage Report for Build 21399061284Details
💛 - Coveralls |
mhliu0001
pushed a commit
that referenced
this pull request
Jan 28, 2026
* Add elife to cs2 corrections * Update condition for cs2 and alt_cs2 assignment
cfuselli
added a commit
that referenced
this pull request
Jan 29, 2026
…G4 (#361) * Modified load_root_file for supporting multiple primary positions in G4 root files. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add elife to cs2 corrections (#368) * Add elife to cs2 corrections * Update condition for cs2 and alt_cs2 assignment * Release 1.6.2 (#369) * Bump version: 1.6.1 → 1.6.2 * Update HISTORY.md for version 1.6.2 * Update HISTORY.md to remove changelog link Removed the full changelog link from the HISTORY.md file. * Fix root input to accept both 1D primary per event and 2D * bump plugin version --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Saad el Morabit <selmorab@nikhef.nl> Co-authored-by: Carlo Fuselli <cfuselli@nikhef.nl> Co-authored-by: Minghao Liu <mhliu0001@sina.com>
cfuselli
added a commit
that referenced
this pull request
Jan 29, 2026
* Add elife to cs2 corrections * Update condition for cs2 and alt_cs2 assignment
cfuselli
added a commit
that referenced
this pull request
Jan 29, 2026
…G4 (#361) * Modified load_root_file for supporting multiple primary positions in G4 root files. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add elife to cs2 corrections (#368) * Add elife to cs2 corrections * Update condition for cs2 and alt_cs2 assignment * Release 1.6.2 (#369) * Bump version: 1.6.1 → 1.6.2 * Update HISTORY.md for version 1.6.2 * Update HISTORY.md to remove changelog link Removed the full changelog link from the HISTORY.md file. * Fix root input to accept both 1D primary per event and 2D * bump plugin version --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Saad el Morabit <selmorab@nikhef.nl> Co-authored-by: Carlo Fuselli <cfuselli@nikhef.nl> Co-authored-by: Minghao Liu <mhliu0001@sina.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding also elife to the cs2 corrections.
In #363 and #364 from last month we changed the way the cs2 field in fuse is overwritten from straxen corrected areas. We do not want to include time dependent corrections but we do want to include the elife correction (because its from a model, not from relative time). We also include xy and peak bias corrections.
In the past we used to set cs2 of fuse to cs2_wo_timecorr, and this included both xy and elife (see here) (note the peak bias correction did not exist yet).
Not with this PR we set cs2 in fuse to cs2_w_bias_xy_elife.