Skip to content

Add cut name to volume selection CutPlugin#366

Merged
cfuselli merged 2 commits into
mainfrom
debug_cut_plugins
Jan 29, 2026
Merged

Add cut name to volume selection CutPlugin#366
cfuselli merged 2 commits into
mainfrom
debug_cut_plugins

Conversation

@Ananthu-Ravindran

Copy link
Copy Markdown
Contributor

Patch to add cut name to Volume Selection plugin. It is registered as a strax.CutPlugin but doesn't have a cut_name. This will throw an error when you do st.registered_cut_versions(). Does not affect the simulation in anyway.

@coveralls

coveralls commented Jan 14, 2026

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 21470905523

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 72.492%

Totals Coverage Status
Change from base Build 21470856302: 0.008%
Covered Lines: 2659
Relevant Lines: 3668

💛 - Coveralls

@cfuselli cfuselli changed the title add cut name Add cut name to volume selection CutPlugin Jan 29, 2026
@cfuselli cfuselli self-requested a review January 29, 2026 08:51

@cfuselli cfuselli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ananthu!

@cfuselli cfuselli merged commit 6a46828 into main Jan 29, 2026
6 checks passed
@cfuselli cfuselli deleted the debug_cut_plugins branch January 29, 2026 08:52
cfuselli added a commit that referenced this pull request Jan 29, 2026
Co-authored-by: Carlo Fuselli <cfuselli@nikhef.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants