Docs: Add a small note about native methods#736
Closed
3fbaea00 wants to merge 0 commit into
Closed
Conversation
Washi1337
reviewed
Apr 26, 2026
Washi1337
left a comment
Washi1337
left a comment
Owner
There was a problem hiding this comment.
Small comment but other than that lgtm. Also, please base your PR on the development branch instead of master.
|
|
||
| > [!NOTE] | ||
| > There are restrictions on the location of native methods in the | ||
| > CLR core implementation: they can only be located in the global <Module> class. |
Author
oops, my bad. i hope github's branch change works as expected and i will not have to create a new pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using AsmResolver, I ran into an issue where the assembly containing my created native methods (following the guide) would not load. It took me a long time to figure out the reason, which I have now documented in the commit note.
Even though the MSIL specification does not explicitly state that native methods must be defined in , the CoreCLR implementation includes code in coreclr\vm\methodtablebuilder.cpp [MethodTableBuilder::ValidateMethods] that checks for IsGlobalClass(). Because of this, I think this note is worth existing