Race and onchain#160
Open
Sadeequ wants to merge 2 commits into
Open
Conversation
Contributor
|
@Sadeequ is attempting to deploy a commit to the K1NGD4VID Team on Vercel. A member of the Team first needs to authorize it. |
|
@Sadeequ Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've successfully implemented all the requested fixes to eliminate hardcoded mock data and resolve race conditions:
Landing Page Stats Fix: I replaced hardcoded mock values (12.4M USDC pool value, 4,821 invoices funded, 245.8K yield distributed) in
apps/web/app/page.tsxwith real data from the usePool hook. I implemented proper loading states with skeleton UI and error handling, along with number formatting functions to display large values correctly.InvoiceFeed Component Fix: I modified apps/web/components/shared/InvoiceFeed.tsx to use real recent events from the useRecentEvents hook instead of mockFeedItems. I added proper event formatting, periodic updates for live feed simulation, and loading/error states to ensure only real on-chain data is displayed.
TopStatusBar Component Fix: I updated apps/web/components/shared/TopStatusBar.tsx to use real event data from the useRecentEvents hook instead of mock tickerItems. The ticker now displays actual transaction data with proper formatting, placeholder content when no data is available, and visual indicators for loading/error states.
Race Condition Fix:
I resolved the TOCTOU race condition in
/workspaces/TrusTrove-app/indexer/api/handlers.goby:Changing statsMu from sync.Mutex to sync.RWMutex
Implementing a proper read-write mutex pattern in HandleGetStats:
Using read lock for cache checks
Releasing read lock and taking write lock only when cache update is needed
Double-checking cache validity after acquiring write lock
Ensuring proper lock release in all execution paths
All changes ensure that users see only real on-chain data with appropriate loading states, eliminating misleading mock statistics while maintaining system performance under concurrent load.
Related Issues:
CLOSES #67 ✔️
CLOSES #68 ✔️