Skip to content

[YouTube] Improve extraction of comments edited state#1514

Merged
AudricV merged 2 commits into
TeamNewPipe:devfrom
unleashedme:dev
Jun 20, 2026
Merged

[YouTube] Improve extraction of comments edited state#1514
AudricV merged 2 commits into
TeamNewPipe:devfrom
unleashedme:dev

Conversation

@unleashedme

@unleashedme unleashedme commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Description

This PR is in the reference of suggested changes from merged PR #1513

@TobiGr

TobiGr commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Thank you. Please use git rebase to update your branch and remove the merge commit.

May I ask if your contribution is part of a uni or school class? (I am collecting information on and comparing various software engineering courses that encourage OSS development as part of their curriculum for research purposes)

@TobiGr TobiGr added the code quality Improvements to the codebase to improve the code quality label Jun 17, 2026
@unleashedme

Copy link
Copy Markdown
Contributor Author

@TobiGr git rebase is done.
No, this contribution is not a part of any uni or school class. I was just trying to start some Open Source Contributions.

@TobiGr TobiGr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just trying to start some Open Source Contributions.

Great! Thank you

@AudricV AudricV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, please change the exception message of the ParsingExceptions to something more useful than the one of the exception you're wrapping and it will be merged :)

@AudricV AudricV changed the title Add Parsing Exception and resolve code nits [YouTube] Improve extraction of comments edited state Jun 19, 2026
@AudricV AudricV added the YouTube Service, https://www.youtube.com/ label Jun 19, 2026
@unleashedme

Copy link
Copy Markdown
Contributor Author

@AudricV changes done.
Do i need to squash these multiple commits??

@AudricV AudricV left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unleashedme Not in this case, we can do this in the merge :)

@AudricV AudricV merged commit 4916927 into TeamNewPipe:dev Jun 20, 2026
2 of 3 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Improvements to the codebase to improve the code quality YouTube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants