input: touchscreen: use -EPROBE_DEFER when panel not ready#4
Open
zaheen4 wants to merge 1 commit into
Open
Conversation
When the DSI panel driver hasn't registered yet, returning -ENODEV permanently fails the touch driver probe. Use -EPROBE_DEFER so the kernel retries after the panel driver probes. This is a latent bug exposed by Clang 20+ reversed probe ordering but is correct regardless of toolchain: a missing dependency should always trigger deferred probing, not permanent failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the DSI panel driver hasn't registered yet, the chipone and ilitek touch drivers return -ENODEV (permanent failure) instead of -EPROBE_DEFER (retry). With Clang 12 (SushiKernel's pinned toolchain) the panel probes first, so this is latent — but Clang 20+ reverses probe ordering, causing the touch driver to fail permanently.
Fix all three chipone variants and the ilitek v3 driver to return -EPROBE_DEFER when the panel dependency is not ready.