Populate personal info riding records from race tracking by TubaApollo · Pull Request #231 · Story-Of-Alicia/alicia-server

TubaApollo · 2026-03-12T23:49:36Z

Implements Riding records in My info Basic tab.
Related to #110

What works

Distance, top speed, longest gliding distance
Completion rate, average rank
Jump success rate, perfect jump success rate, consecutive perfect jumps
Best boost combo
Best magic defense combo
Win streaks (speed/magic, solo/team)
Magic item usage counts (stored but success rates need hit detection)

Known limitations

Magic attack success rates (magic ball, fire spirit, ice wall): usage is tracked but hit detection requires relay
passthrough parsing (P2P data)
Avg chasing count --> needs relay passthrough parsing
Level progress --> needs level/XP table
Biggest carnival prize --> carnival system does not award prizes yet
Ceremony IDs needs achievement system

Rename unknown memberXX fields in AcCmdLCPersonalInfo::Basic based on client RE (Ghidra analysis of FUN_008a8ef0 UI update function). Populate mount statistics (distance, speed, wins, combos, carnival prize) in HandleRequestPersonalInfo from active mount's MountInfo. Computed stats (jump rates, avg rank, completion rate) left as 0 until race result tracking is implemented. Related to Story-Of-Alicia#115

Extracted UI labels from res.pak XML templates (myinfo_dialog.xml) and matched them to packet fields via Ghidra RE + Y-position pairing: - record7Stat → averageChasingCount (체이싱 평균 횟수) - record18Rate → magicBallAttackSuccessRate (마법구 공격 성공율) - record19Rate → fireSpiritTransferSuccessRate (화염의 정령 옮기기 성공율) - record17Rate → iceWallAttackSuccessRate (빙벽 공격 성공율)

Add cumulative counters to MountInfo, update during hurdle clear events and race completion, compute derived stats for personal info.

- Rename AcCmdUserRaceUpdatePos members to semantic names (position, rotation, speed, airborne, trackProgress) - Rename personal info fields from RE findings: uiState14/15/16 -> ceremonyId1/2/3 (achievement ceremony slots) record20String -> legacyGradeString (unused by client) flag28/29 -> padding28/29 (not accessed by UI handler) - Track distance, max speed and longest glide per race session in RaceTracker::Racer, persisted to MountInfo at race end - Speed and glide stored as value * 10 for client display format Not yet implemented (each needs a separate feature branch): - magicBallAttackSuccessRate, fireSpiritTransferSuccessRate, iceWallAttackSuccessRate: usage counts exist in mountInfo but hit detection requires relay message parsing (P2P passthrough) - averageChasingCount: "chasing" is a MissionType in the NPC quest system (RcUILogicMissionChase). Needs quest/mission system (see origin/feature/quests) - levelProgress: needs character XP field, LevelInfo threshold table from libconfig_c.dat (100 levels), and XP earning logic - ceremonyId1/2/3: achievement ceremony slot IDs for profile icons, needs achievement system

…stants - Add missing mountUid != InvalidUid guards in jump tracking - Fix glide tracking to count takeoff tick and handle teleport resets - Replace magic item ID literals with named constexpr constants - Document sessionMaxSpeed unit and defense combo P2P relay flow

- Track consecutive boosts in HandleRequestSpur (reset on comboBreak) - Flush best boost combo to boostsInARow at race end - Update win streak counters based on game mode and team mode

- Replace {0u} with {} on dao::Field members to match existing style - Document that team mode win streaks use individual rank as placeholder

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Add AcCmdCRSetKeyEmblemNotify, AcCmdCRSetKeyEmblem request/OK/cancel protocol messages. Populate emblem list with IDs 1-35 from EmblemInfo table. Route emblem notify through RanchDirector for cross-server delivery when viewing personal info in the lobby.

TubaApollo · 2026-03-14T01:38:24Z

The client parses this field but never reads it back. The txt_grade label in the profile UI is populated from a client-side EmblemTable lookup instead.

rgnter · 2026-03-14T16:17:34Z

+          _serverInstance.GetDataDirector().GetHorse(
+                                             character.mountUid())


Suggested change

_serverInstance.GetDataDirector().GetHorse(

character.mountUid())

_serverInstance.GetDataDirector().GetHorse(character.mountUid())

rgnter · 2026-03-14T16:25:51Z

+  if (emblemId > 0 && emblemId <= 35)
+  {
+    const auto& lobbyContext = GetClientContext(clientId);
+    _serverInstance.GetRanchDirector().SendEmblemNotify(


Why does this need to happen here? AcCmdCRSetKeyEmblemNotify is only supposed to send notification about picked emblems after user explicitly changes them. Why do you force it here?

Without this, when player A views player B's profile after B changed their emblem, the profile dialog shows the new emblem but the emblem above B's head still shows the old one. The notify syncs the overhead emblem display when another player opens your profile.

Yeah that's how notify works, but you're sending it when player is logging in (and only to them) for some reason.

Okay I rechecked. I think there are two options:
Either accept the mismatch between profile dialog and overhead emblem. The profile dialog will show the correct emblem, but the overhead display stays stale when a user changed it.

Edit: Or keep the notify. Tried to recheck with xdbg:

BroadcastEmblemNotify in HandleSetKeyEmblem does update the client's local character cache, but doesn't trigger a visual refresh of the overhead emblem

Opening the profile alone also doesn't refresh the overhead

The notify sent while the profile dialog is open is what triggers the actual visual update of the overhead emblem

If we keep it, I'll add a guard so it only fires when viewing another player's profile, not on login.

Since it's not completely clear why this only works with the profile dialog open, it might be better to just remove it and accept the mismatch.

HandleRequestPersonalInfo is invoked when someone clicks on someone's profile. If overhead emblem and emblem in profile are mismatched we're missing something. Can you please record the behavior and send it in #server-development on discord?

We simply cannot be sending this here, it is incorrect.

I think I finally found out why.
When AcCmdCRSetKeyEmblemNotify fires, client dispatches gMsgUIChangeKeyEmblem. Two subscribers react with the same priority, the Overhead Handler and the Cache Updater. But the Overhead Handler fires BEFORE the Cache Updater. (confirmed with xdbg) Thats why the Overhead reads the old value.

I fixed it now by sending the same notify twice. It's not perfect but I don't think there is any better way to do it?

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

The client's overhead emblem handler reads from a character cache that is updated by a separate signal subscriber firing after it. Send the notify twice so the second dispatch reads the correct value. Remove the workaround that sent EmblemNotify from HandleRequestPersonalInfo.

Only count racers who crossed the finish line (courseTime >= 0) toward totalFinished and cumulativeRank. Previously any non-disconnected racer was counted, so DNF players inflated the completion rate to 100%.

xen1i · 2026-03-19T06:57:04Z

+        // Mount statistics from active mount
+        if (character.mountUid() == data::InvalidUid)
+          return;
+
+        const auto mountRecord = _serverInstance.GetDataDirector().GetHorse(
+          character.mountUid());
+
+        if (not mountRecord)
+          return;
+
+        mountRecord.Immutable([&response](const data::Horse& horse)
+        {
+          response.basic.distanceTravelled = horse.mountInfo.totalDistance();
+          response.basic.topSpeed = horse.mountInfo.topSpeed();
+          response.basic.longestGlidingDistance = horse.mountInfo.longestGlideDistance();
+          response.basic.speedSingleWinCombo = static_cast<uint16_t>(
+            horse.mountInfo.winsSpeedSingle());
+          response.basic.speedTeamWinCombo = static_cast<uint16_t>(
+            horse.mountInfo.winsSpeedTeam());
+          response.basic.magicSingleWinCombo = static_cast<uint16_t>(
+            horse.mountInfo.winsMagicSingle());
+          response.basic.magicTeamWinCombo = static_cast<uint16_t>(
+            horse.mountInfo.winsMagicTeam());
+          response.basic.highestCarnivalPrize = horse.mountInfo.biggestPrize();
+          response.basic.perfectBoostCombo = static_cast<uint16_t>(
+            horse.mountInfo.boostsInARow());
+
+          // Computed race stats from persistent counters
+          if (horse.mountInfo.totalJumps() > 0)
+          {
+            const float successfulJumps = static_cast<float>(horse.mountInfo.successfulJumps());
+            const float perfectJumps = static_cast<float>(horse.mountInfo.perfectJumps());
+            const float totalJumps = static_cast<float>(horse.mountInfo.totalJumps());
+
+            response.basic.jumpSuccessRate = successfulJumps / totalJumps;
+            response.basic.perfectJumpSuccessRate = perfectJumps / totalJumps;
+          }
+
+          const float totalFinished = static_cast<float>(horse.mountInfo.totalFinished());
+
+          if (horse.mountInfo.totalFinished() > 0)
+          {
+            const float cumulativeRank = static_cast<float>(horse.mountInfo.cumulativeRank());
+            response.basic.averageRank = cumulativeRank / totalFinished;
+          }
+
+          if (horse.mountInfo.totalRaces() > 0)
+          {
+            const float totalRaces = static_cast<float>(horse.mountInfo.totalRaces());
+            response.basic.completionRate = totalFinished / totalRaces;
+          }
+
+          response.basic.perfectJumpCombo = static_cast<uint16_t>(
+            horse.mountInfo.bestJumpCombo());
+          response.basic.magicDefenseCombo = static_cast<uint16_t>(
+            horse.mountInfo.bestMagicDefenseCombo());
+
+          // TODO: Magic attack SUCCESS RATES require relay passthrough
+          // parsing to detect hits (P2P data). Usage counts are tracked
+          // in mountInfo but hit counts need feature/reverse-relay-data.
+          // Fields: magicBallAttackSuccessRate, fireSpiritTransferSuccessRate,
+          //         iceWallAttackSuccessRate, averageChasingCount
+          // TODO: levelProgress needs res.pak level/XP table extraction
+        });
+


This should be the lifetime stats of the player, not the current horse.

Changed to character stats now

xen1i · 2026-03-19T07:10:38Z

+void RanchDirector::BroadcastEmblemNotify(
+  const data::Uid characterUid,
+  const uint16_t emblemId)
+{
+  try
+  {
+    const auto& clientContext = GetClientContextByCharacterUid(characterUid);
+
+    // Send twice - the client's overhead handler reads from a cache
+    // that is updated by a later subscriber in the signal chain.
+    protocol::AcCmdCRSetKeyEmblemNotify notify{
+      .characterUid = static_cast<uint32_t>(characterUid),
+      .emblemId = emblemId};
+
+    for (const ClientId ranchClientId : _ranches[clientContext.visitingRancherUid].clients)
+    {
+      _commandServer.QueueCommand<decltype(notify)>(
+        ranchClientId,
+        [notify]()
+        {
+          return notify;
+        });
+      _commandServer.QueueCommand<decltype(notify)>(
+        ranchClientId,
+        [notify]()
+        {
+          return notify;
+        });
+    }
+  }
+  catch (const std::exception&)
+  {
+    // Empty.
+  }
+}
+


We shouldn't send the notify twice, once should be enough.
Also we should prevent self broadcasting.

Self-broadcast is fixed. Don't really know how to proceed with the notify, I can remove it but then it would need a client patch to work.

Personal info stats now iterate all horses (stable + active mount) instead of reading only the active mount. Sums cumulative counters, takes max for records/combos. Remove unused SendEmblemNotify (replaced by BroadcastEmblemNotify). Add self-broadcast prevention to BroadcastEmblemNotify.

Add Character::RidingStats for lifetime stats that persist across horse changes. Race stats are now written to both the horse (per-mount view) and the character (personal info). Personal info reads directly from character.ridingStats instead of aggregating across horses.

Keep magic item usage tracking and add magicSlotInfo lookup from master.

TubaApollo added 8 commits March 9, 2026 01:45

feat: track race and jump statistics persistently in mount data

894aa5d

Add cumulative counters to MountInfo, update during hurdle clear events and race completion, compute derived stats for personal info.

feat: track boost combo and win streaks in race statistics

eaf8d25

- Track consecutive boosts in HandleRequestSpur (reset on comboBreak) - Flush best boost combo to boostsInARow at race end - Update win streak counters based on game mode and team mode

fix: use consistent {} initialization and add team win streak TODO

de9dd59

- Replace {0u} with {} on dao::Field members to match existing style - Document that team mode win streaks use individual rank as placeholder

style: apply clang-format to new code

e2653e0

rgnter self-requested a review March 13, 2026 07:50

rgnter requested changes Mar 13, 2026

View reviewed changes

TubaApollo and others added 10 commits March 13, 2026 13:57

Update include/libserver/network/command/proto/LobbyMessageDefinition…

434577f

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update include/libserver/network/command/proto/LobbyMessageDefinition…

e69fbd1

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update include/libserver/network/command/proto/LobbyMessageDefinition…

2707c4f

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update src/server/race/RaceDirector.cpp

3fc368d

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update src/server/race/RaceDirector.cpp

f4a684b

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update src/server/race/RaceDirector.cpp

857b152

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update src/server/race/RaceDirector.cpp

72044f8

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Rename ceremonyId to ceremonySlot, legacyGradeString to gradeTitle

d9ea435

Fix magic item tracking, add Summon for fire spirit

7b6f637

Fix team win stats to not reset on loss

258fc94

rgnter requested changes Mar 13, 2026

View reviewed changes

Comment thread include/libserver/network/command/proto/LobbyMessageDefinitions.hpp Outdated

TubaApollo added 2 commits March 13, 2026 18:23

Flatten mount stats with early returns and named variables

203bb98

Remove duplicate comment on padding field

8565d6f

rgnter requested changes Mar 13, 2026

View reviewed changes

Comment thread include/libserver/data/DataDefinitions.hpp

TubaApollo added 5 commits March 13, 2026 18:53

Rename ceremonySlot to ceremonyAchievementSlot1-3

b4eff96

Replace em dashes with hyphens in comments

18e05bb

Add per-field doxygen comments to mount info counters

60d2fca

Fix locked ranch bypass, restore missing early return

5789317

Rename gradeTitle to unk_gradeString, document client ignores it

9c901e7

The client parses this field but never reads it back. The txt_grade label in the profile UI is populated from a client-side EmblemTable lookup instead.

rgnter requested changes Mar 14, 2026

View reviewed changes

TubaApollo and others added 14 commits March 14, 2026 22:33

Fix unk_gradeString comment: EmblemTable -> AchievementGrade

412c83b

Update include/libserver/network/command/proto/LobbyMessageDefinition…

1497429

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update include/libserver/network/command/proto/LobbyMessageDefinition…

73918dd

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Fix ternary and lambda indentation in RaceDirector

8e15962

Update include/libserver/network/command/proto/RanchMessageDefinition…

1fe1171

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update include/libserver/network/command/proto/RanchMessageDefinition…

f6b1736

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update src/libserver/network/command/proto/RanchMessageDefinitions.cpp

49ad848

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update include/libserver/network/command/proto/RanchMessageDefinition…

acf5cc9

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Update include/libserver/network/command/proto/RanchMessageDefinition…

d03b621

…s.hpp Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Fix GetHorse call alignment in RaceDirector

43ba547

Update src/libserver/network/command/proto/RanchMessageDefinitions.cpp

eef5b98

Co-authored-by: Maroš Prejsa <maros.prejsa1@gmail.com>

Add BroadcastEmblemNotify, use it in HandleSetKeyEmblem

90b4c14

Fix completion rate counting DNF racers as finished

9b36c46

Only count racers who crossed the finish line (courseTime >= 0) toward totalFinished and cumulativeRank. Previously any non-disconnected racer was counted, so DNF players inflated the completion rate to 100%.

xen1i reviewed Mar 19, 2026

View reviewed changes

Comment thread src/server/ranch/RanchDirector.cpp Outdated

xen1i reviewed Mar 19, 2026

View reviewed changes

xen1i requested changes Mar 19, 2026

View reviewed changes

TubaApollo added 4 commits March 20, 2026 00:52

Remove stale TODO - per-horse stats view already implemented

afc12c1

Resolve merge conflict in RaceDirector.cpp

f2d6ecc

Keep magic item usage tracking and add magicSlotInfo lookup from master.

		_serverInstance.GetDataDirector().GetHorse(
		character.mountUid())

Uh oh!

Conversation

TubaApollo commented Mar 12, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TubaApollo commented Mar 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TubaApollo Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TubaApollo Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rgnter Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TubaApollo Mar 14, 2026 •

edited

Loading

TubaApollo Mar 17, 2026 •

edited

Loading

rgnter Mar 17, 2026 •

edited

Loading