Fix guild invite acceptance handling#227
Open
Koaio wants to merge 4 commits into
Open
Conversation
Validate character/guild UIDs and pending invites before joining, and update character guildUid only after successful guild membership.
Koaio
commented
Mar 16, 2026
Koaio
left a comment
Koaio
left a comment
Contributor
Author
There was a problem hiding this comment.
For me we can merge
rgnter
requested changes
May 4, 2026
|
|
||
| const auto& clientContext = GetClientContext(clientId); | ||
|
|
||
| // Basic sanity check: command character must match connected character |
Member
There was a problem hiding this comment.
Suggested change
| // Basic sanity check: command character must match connected character | |
| // Sanity check the requested character matches the client character. |
| const auto& clientContext = GetClientContext(clientId); | ||
|
|
||
| // Basic sanity check: command character must match connected character | ||
| if (command.characterUid != clientContext.characterUid) |
Member
There was a problem hiding this comment.
characterUid is the UID of the character that is being invited, you should be checking inviterCharacterName. Can you please test the behaviour in the future before submitting PRs?
|
|
||
| // Check that the guild instance exists in lobby state | ||
| auto& guildInstances = _serverInstance.GetLobbyDirector().GetGuilds(); | ||
| const auto guildInstanceIt = guildInstances.find(command.guild.uid); |
Member
There was a problem hiding this comment.
You need to verify the command.guild.uid as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate character/guild UIDs and pending invites before joining, and update character guildUid only after successful guild membership.